Tests for clearsky.reno fail with pvlib 0.8.1

[wfvining]

PVLib 0.8.1 changed the labeling of clear-sky periods (pvlib/pvlib-python#1074) which is resulting in a test failures in test_clearsky.py.

The change in pvlib labels windows on the center by default, while previous behavior labeled on the left. We probably want to accept the new default behavior from PVLib (updating the tests to match) and expose the new align parameter in pvanalytics.clearsky.reno.

[cwhanse]

The change in pvlib labels windows on the left by default, while previous behavior used centered labels.

Other way around; before v0.8.1, pvlib used left labels. pvlib v0.8.1 uses centered labels.

[wfvining]

Other way around; before v0.8.1, pvlib used left labels. pvlib v0.8.1 uses centered labels.

Thanks, updated.

[wfvining]

Actually, the alignment is not exposed in the pvlib API. We should probably just accept the centered labels here, and remove/rewrite tests that relied on left-aligned labels. I'm thinking that my approach to testing this function was flawed to begin with, it might be better to mock the pvlib function and check that the window/scale are computed correctly and passed the pvlib function (otherwise we are spending a bunch of effort testing code that isn't even part of pvanalytics).

[cwhanse]

Tests for clearsky.reno fail because of a bug in pvlib.clearsky #pvlib/pvlib-python#1241