Skip to content

Commit d988a7e

Browse files
authored
Merge pull request #1415 from pulp/patchback/backports/3.11/52c60bc9a809521e462b8f5545b1e1b03910bd67/pr-1412
[PR #1412/52c60bc9 backport][3.11] [3.19] Autoescape data when rendering simple detail html
2 parents de3e751 + 8e28ad6 commit d988a7e

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed quoting mistake in simple html detail pages that can lead to a possible XSS attack.

‎pulp_python/app/utils.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,6 @@ def write_simple_index(project_names, streamed=False):
310310

311311
def write_simple_detail(project_name, project_packages, streamed=False):
312312
"""Writes the simple detail page of a package."""
313-
detail = Template(simple_detail_template)
313+
detail = Template(simple_detail_template, autoescape=True)
314314
context = {"project_name": project_name, "project_packages": project_packages}
315315
return detail.stream(**context) if streamed else detail.render(**context)

0 commit comments

Comments
 (0)