From c4d2d932f911260bf1c5e2ffd5b012cd346e6ae6 Mon Sep 17 00:00:00 2001 From: Paul Santus Date: Tue, 8 Sep 2026 11:41:50 +0200 Subject: [PATCH] chore(ci): bump actions/checkout to v5 + opt into Node 24 - actions/checkout@v4 -> @v5 (the only action with a Node 24 release today) - FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true at workflow level to silence the Node 20 warnings for actions still lacking a Node 24 major (docker/*, setup-terraform, setup-php, cache, aws-actions/*) until upstream ships them (GitHub forces Node 24 by June 2026). --- .github/workflows/ci.yml | 14 ++++++++++---- .github/workflows/deploy.yml | 8 +++++++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 90d2854..893ff24 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,11 +9,17 @@ on: pull_request: workflow_dispatch: +# Opt every JavaScript action into Node.js 24 now (GitHub forces it by June 2026). +# Silences the Node 20 deprecation warnings for actions that don't yet ship a +# Node 24 major (docker/*, setup-terraform, setup-php). +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" + jobs: terraform: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: hashicorp/setup-terraform@v3 - name: fmt run: terraform fmt -check -recursive iac/ @@ -31,7 +37,7 @@ jobs: php-lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: shivammathur/setup-php@v2 with: php-version: '8.5' @@ -44,14 +50,14 @@ jobs: shell-lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - name: bash -n on scripts run: for s in spip/scripts/*.sh; do bash -n "$s"; done docker-build: runs-on: ubuntu-24.04-arm steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: docker/setup-buildx-action@v3 - name: Read pinned SPIP version run: echo "SPIP_VERSION=$(cat spip/SPIP_VERSION)" >> "$GITHUB_ENV" diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index ca76aa9..e699337 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -29,6 +29,12 @@ concurrency: group: deploy-${{ github.ref_name }} cancel-in-progress: false +# Opt every JavaScript action into Node.js 24 now (GitHub forces it by June 2026). +# Silences the Node 20 deprecation warnings for actions that don't yet ship a +# Node 24 major (docker/*, setup-terraform, setup-php, cache, aws-actions/*). +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" + jobs: deploy: runs-on: ubuntu-24.04-arm @@ -45,7 +51,7 @@ jobs: AWS_ACCOUNT_ID: ${{ vars.AWS_ACCOUNT_ID }} ECR_REPO: spip-serverless steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - name: Read pinned SPIP version + ADOT layer run: |