Skip to content

Commit 030e506

Browse files
committed
CollectionInterface: clean out completed TODO comments
1 parent f7a6c68 commit 030e506

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

src/Classes/OverrideMapUpdaterClass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ bool OverrideMapUpdater::_xml_check_result(tinyxml2::XMLError a_eResult, tinyxml
229229
::SendMessageA(curScintilla, SCI_ANNOTATIONSETTEXT, zeroLine, reinterpret_cast<LPARAM>(p_doc->ErrorStr()));
230230

231231
// need to stop
232-
// TODO: DO I NEED?? _doAbort = true;
232+
// In ConfigUpdater, I needed to set `_doAbort = true;` to exit out of a loop, but that's needed in CollectionInterface
233233
};
234234
}
235235
return true;

src/Classes/OverrideMapUpdaterClass.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ class OverrideMapUpdater {
3030
tinyxml2::XMLError OverrideMapUpdater::saveFile(std::string sNewPath) { return pOverrideMapXML->SaveFile(sNewPath.c_str()); }
3131
tinyxml2::XMLError OverrideMapUpdater::saveFile(std::wstring wsNewPath) { return pOverrideMapXML->SaveFile(pcjHelper::wstring_to_utf8(wsNewPath).c_str()); }
3232

33-
// TODO: !!!error handling on all XML processing!!!
34-
35-
3633
// getters
3734
std::wstring wsOverMapPath(void) { return _wsOverMapPath; }
3835
std::string sOverMapPath(void) { return pcjHelper::wstring_to_utf8(_wsOverMapPath); }

0 commit comments

Comments
 (0)