From 56515b0bf3ec05af8902b48425c2a35fa1bd2c7c Mon Sep 17 00:00:00 2001 From: Julien Pivotto Date: Tue, 17 May 2022 14:39:02 +0200 Subject: [PATCH 1/2] Add more PromQL tests Signed-off-by: Julien Pivotto --- promql/promql-test-queries.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/promql/promql-test-queries.yml b/promql/promql-test-queries.yml index c601cd8d..91a4b853 100644 --- a/promql/promql-test-queries.yml +++ b/promql/promql-test-queries.yml @@ -45,13 +45,20 @@ test_cases: # TODO: Add tests for staleness support. - query: 'demo_memory_usage_bytes' - query: '{__name__="demo_memory_usage_bytes"}' + # Check for spacing. + - query: ' { __name__ = "demo_memory_usage_bytes" } ' - query: 'demo_memory_usage_bytes{type="free"}' - query: 'demo_memory_usage_bytes{type!="free"}' - query: 'demo_memory_usage_bytes{instance=~"demo.promlabs.com:.*"}' + # Check for anchored regexes. + - query: 'demo_memory_usage_bytes{instance=~"demo.promlabs.com"}' - query: 'demo_memory_usage_bytes{instance=~"host"}' - query: 'demo_memory_usage_bytes{instance!~".*:10000"}' - query: 'demo_memory_usage_bytes{type="free", instance!="demo.promlabs.com:10000"}' - query: '{type="free", instance!="demo.promlabs.com:10000"}' + # Check for using the same label name in different matchers. + - query: '{__name__=~"go_gc_heap_allocs.*",__name__=~".*_sum"}' + - query: '{type="free",type!="free"}' - query: '{__name__=~".*"}' should_fail: true - query: "nonexistent_metric_name" From dfde21ced0ee802709684c0fe978877099e015c0 Mon Sep 17 00:00:00 2001 From: Julien Pivotto Date: Tue, 17 May 2022 15:41:57 +0200 Subject: [PATCH 2/2] Add more delimiters Signed-off-by: Julien Pivotto --- promql/promql-test-queries.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/promql/promql-test-queries.yml b/promql/promql-test-queries.yml index 91a4b853..5f7a6164 100644 --- a/promql/promql-test-queries.yml +++ b/promql/promql-test-queries.yml @@ -48,6 +48,8 @@ test_cases: # Check for spacing. - query: ' { __name__ = "demo_memory_usage_bytes" } ' - query: 'demo_memory_usage_bytes{type="free"}' + - query: 'demo_memory_usage_bytes{type=`free`}' + - query: "demo_memory_usage_bytes{type='free'}" - query: 'demo_memory_usage_bytes{type!="free"}' - query: 'demo_memory_usage_bytes{instance=~"demo.promlabs.com:.*"}' # Check for anchored regexes.