Skip to content

Fix grid-area span reset for overriding areas#1549

Open
puneetdixit200 wants to merge 1 commit into
postcss:mainfrom
puneetdixit200:fix/grid-area-override-span
Open

Fix grid-area span reset for overriding areas#1549
puneetdixit200 wants to merge 1 commit into
postcss:mainfrom
puneetdixit200:fix/grid-area-override-span

Conversation

@puneetdixit200
Copy link
Copy Markdown

Summary

  • Emit -ms-grid-*-span: 1 when a later grid-area rule can overlap an earlier area with a larger span.
  • Add regression coverage for overriding a broad grid-area assignment with narrower child rules.

Tests

  • node node_modules\\uvu\\bin.js test
  • npx --yes pnpm@10.26.0 run test:lint
  • npx --yes pnpm@10.26.0 run test:size
  • npx --yes pnpm@10.26.0 exec c8 node node_modules\\uvu\\bin.js test
  • git diff --check

Fixes #1292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css grid] Overriding a grid-area assignment with more specific one may result in incorrect -ms-grid-(row|column)-span

1 participant