Issue with web based console output not attaching new lines

[X-Coder]

Thank you for your console patch.

I use pterodactyl with this bepinex egg on my dedicated linux server (I had to modify it a little bit to get bepinex starting). It comes with a web based console.

After I added your patch, the output starting to look like this:

The issue is that new output at the end is not appended, but instead overwrites the last line.
In this case, the line at 00:48 keeps getting overwritten instead of having new output appended.

The yellow lines seem to work fine, and I don’t think they were visible before I added your patch, so your patch seems to work until a specific point.

This happens as soon as the game server starts and uses the patch. The startup itself looks fine, and all lines except the last one are appended correctly.

Do you know what might be causing this issue and how it can be fixed?

[X-Coder]

Traced it down, the issue is in the PrintToConsole method of the RocketSystemConsole class.

This patch I created might still contain bugs in some cases, but it fixed it for my case (linux web console does append now + ingame console is unchanged and works too, didn't test shell console).

Commands from input like "status", still outputs at wrong position. This still needs to be fixed.

It works by overriding the original PrintToConsole method and not calling clearLine() and redrawInput():

        [HarmonyPatch("PrintToConsole")]
        [HarmonyPrefix]
        static bool PrintToConsole_Patch(RocketSystemConsole __instance, string output, ConsoleColor colour = ConsoleColor.White)
        {
            var isReady = (bool)typeof(RocketSystemConsole)
                .GetField("_isReady", BindingFlags.NonPublic | BindingFlags.Instance)
                .GetValue(__instance);

            if (!isReady)
            {
                var queue = (Queue<(string, ConsoleColor)>)typeof(RocketSystemConsole)
                    .GetField("_preReadyOutputQueue", BindingFlags.NonPublic | BindingFlags.Instance)
                    .GetValue(__instance);

                queue?.Enqueue((output, colour));
                return false;
            }

            bool isInteractive =
                RuntimeInformation.IsOSPlatform(OSPlatform.Windows) &&
                !Console.IsOutputRedirected;

            Console.ForegroundColor = colour;

            var clearLineMethod = typeof(RocketSystemConsole)
                .GetMethod("ClearLine", BindingFlags.NonPublic | BindingFlags.Instance);

            var redrawInputMethod = typeof(RocketSystemConsole)
                .GetMethod("RedrawInputLine", BindingFlags.NonPublic | BindingFlags.Instance);

            foreach (string line in output.Split('\n'))
            {
                if (isInteractive)
                {
                    clearLineMethod?.Invoke(__instance, null);
                    Console.WriteLine(line);
                    redrawInputMethod?.Invoke(__instance, null);
                }
                else
                {
                    Console.WriteLine(line);
                }
            }

            Console.ResetColor();

            return false;
        }