From 72366909d92601619a2e4d54fbd63cd1a3fe71f4 Mon Sep 17 00:00:00 2001 From: Ewan Date: Fri, 13 Mar 2026 14:20:17 +0200 Subject: [PATCH 1/7] fix(windows): windows branch switch ui broken --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 1 - apps/web/src/components/ui/autocomplete.tsx | 2 +- apps/web/src/components/ui/combobox.tsx | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index 9446279161..e10a624c15 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -387,7 +387,6 @@ export function BranchToolbarBranchSelector({ key={itemValue} index={index} value={itemValue} - className={itemValue === resolvedActiveBranch ? "bg-accent text-foreground" : undefined} style={style} onClick={() => selectBranch(branch)} > diff --git a/apps/web/src/components/ui/autocomplete.tsx b/apps/web/src/components/ui/autocomplete.tsx index 98ad1e431a..89cfcd375f 100644 --- a/apps/web/src/components/ui/autocomplete.tsx +++ b/apps/web/src/components/ui/autocomplete.tsx @@ -125,7 +125,7 @@ function AutocompleteItem({ className, children, ...props }: AutocompletePrimiti return ( Date: Fri, 13 Mar 2026 22:37:56 +0200 Subject: [PATCH 2/7] Unify branch selector item highlight styling - Apply shared hover/selected/highlight class to all branch combobox items - Keep branch action rows and branch rows visually consistent in the selector --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index e10a624c15..0460e66780 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -326,11 +326,14 @@ export function BranchToolbarBranchSelector({ effectiveEnvMode, resolvedActiveBranch, }); + const branchSelectorHighlightClassName = + "hover:bg-[#242424] hover:text-white data-selected:bg-[#242424] data-selected:text-white data-highlighted:bg-[#242424] data-highlighted:text-white"; function renderPickerItem(itemValue: string, index: number, style?: CSSProperties) { if (checkoutPullRequestItemValue && itemValue === checkoutPullRequestItemValue) { return ( Date: Sat, 28 Mar 2026 00:07:22 +0200 Subject: [PATCH 3/7] fix(web): restore themed branch selector states --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index 70fc38b414..25bb021c9b 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -337,7 +337,7 @@ export function BranchToolbarBranchSelector({ resolvedActiveBranch, }); const branchSelectorHighlightClassName = - "hover:bg-[#242424] hover:text-white data-selected:bg-[#242424] data-selected:text-white data-highlighted:bg-[#242424] data-highlighted:text-white"; + "hover:bg-accent hover:text-accent-foreground data-selected:bg-accent/50 data-selected:text-foreground data-highlighted:bg-accent data-highlighted:text-accent-foreground"; function renderPickerItem(itemValue: string, index: number, style?: CSSProperties) { if (checkoutPullRequestItemValue && itemValue === checkoutPullRequestItemValue) { From 377f62cb9060c726874d291f5b42ca5de5d87abf Mon Sep 17 00:00:00 2001 From: Ewan Date: Sat, 28 Mar 2026 00:33:51 +0200 Subject: [PATCH 4/7] fix(web): tune selected branch row surface --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index 25bb021c9b..d30d10330f 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -337,7 +337,7 @@ export function BranchToolbarBranchSelector({ resolvedActiveBranch, }); const branchSelectorHighlightClassName = - "hover:bg-accent hover:text-accent-foreground data-selected:bg-accent/50 data-selected:text-foreground data-highlighted:bg-accent data-highlighted:text-accent-foreground"; + "hover:bg-accent hover:text-accent-foreground data-selected:bg-accent/50 dark:data-selected:bg-input/64 data-selected:text-foreground data-highlighted:bg-accent data-highlighted:text-accent-foreground"; function renderPickerItem(itemValue: string, index: number, style?: CSSProperties) { if (checkoutPullRequestItemValue && itemValue === checkoutPullRequestItemValue) { From a449e613cc8ae432352a713ad37b7e81e4a624a9 Mon Sep 17 00:00:00 2001 From: Ewan Date: Sat, 28 Mar 2026 00:41:19 +0200 Subject: [PATCH 5/7] fix(web): align branch selector hover surface --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index d30d10330f..d4ad490a25 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -337,7 +337,7 @@ export function BranchToolbarBranchSelector({ resolvedActiveBranch, }); const branchSelectorHighlightClassName = - "hover:bg-accent hover:text-accent-foreground data-selected:bg-accent/50 dark:data-selected:bg-input/64 data-selected:text-foreground data-highlighted:bg-accent data-highlighted:text-accent-foreground"; + "hover:bg-accent dark:hover:bg-input/64 hover:text-accent-foreground data-selected:bg-accent/50 dark:data-selected:bg-input/64 data-selected:text-foreground data-highlighted:bg-accent dark:data-highlighted:bg-input/64 data-highlighted:text-accent-foreground"; function renderPickerItem(itemValue: string, index: number, style?: CSSProperties) { if (checkoutPullRequestItemValue && itemValue === checkoutPullRequestItemValue) { From ef1bdc73ec0cd0b58623d67e35cec214bd87688a Mon Sep 17 00:00:00 2001 From: Ewan Date: Sat, 28 Mar 2026 00:45:13 +0200 Subject: [PATCH 6/7] fix(web): use consistent branch selector highlight tone --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index d4ad490a25..b9e294456b 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -337,7 +337,7 @@ export function BranchToolbarBranchSelector({ resolvedActiveBranch, }); const branchSelectorHighlightClassName = - "hover:bg-accent dark:hover:bg-input/64 hover:text-accent-foreground data-selected:bg-accent/50 dark:data-selected:bg-input/64 data-selected:text-foreground data-highlighted:bg-accent dark:data-highlighted:bg-input/64 data-highlighted:text-accent-foreground"; + "hover:bg-accent/50 hover:text-foreground data-selected:bg-accent/50 data-selected:text-foreground data-highlighted:bg-accent/50 data-highlighted:text-foreground"; function renderPickerItem(itemValue: string, index: number, style?: CSSProperties) { if (checkoutPullRequestItemValue && itemValue === checkoutPullRequestItemValue) { From 8b038844a68225d32209783e1a9bba111f88ec14 Mon Sep 17 00:00:00 2001 From: Ewan Date: Sat, 28 Mar 2026 00:47:24 +0200 Subject: [PATCH 7/7] fix(web): use hover tone for selected branch rows --- apps/web/src/components/BranchToolbarBranchSelector.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/components/BranchToolbarBranchSelector.tsx b/apps/web/src/components/BranchToolbarBranchSelector.tsx index b9e294456b..6c2277e7fa 100644 --- a/apps/web/src/components/BranchToolbarBranchSelector.tsx +++ b/apps/web/src/components/BranchToolbarBranchSelector.tsx @@ -337,7 +337,7 @@ export function BranchToolbarBranchSelector({ resolvedActiveBranch, }); const branchSelectorHighlightClassName = - "hover:bg-accent/50 hover:text-foreground data-selected:bg-accent/50 data-selected:text-foreground data-highlighted:bg-accent/50 data-highlighted:text-foreground"; + "hover:bg-accent hover:text-accent-foreground data-selected:bg-accent data-selected:text-accent-foreground data-highlighted:bg-accent data-highlighted:text-accent-foreground"; function renderPickerItem(itemValue: string, index: number, style?: CSSProperties) { if (checkoutPullRequestItemValue && itemValue === checkoutPullRequestItemValue) {