[UPD] rel v4.0.0

Author: GianfriAur

CHANGELOG.md

@@ -10,3 +10,4 @@
 - NodeSet2.xml code generator: typed DTOs, PHP enums, binary codecs, registrar with dependency resolution.
 - Server address space dump to NodeSet2.xml.
 - Server certificate trust management from the terminal.
+- **272 tests** (253 unit + 19 integration), 592 assertions, **99.9% code coverage**.

CONTRIBUTING.md

@@ -35,6 +35,8 @@ docker compose up -d
 
 ## Running Tests
 
+The project currently has **272 tests** (253 unit + 19 integration) with 592 assertions and **99.9% code coverage**.
+
 ```bash
 # All tests
 ./vendor/bin/pest
@@ -48,7 +50,7 @@ docker compose up -d
 # A specific test file
 ./vendor/bin/pest tests/Unit/ArgvParserTest.php
 
-# With coverage report
+# With coverage report (requires pcov)
 php -d pcov.enabled=1 ./vendor/bin/pest --coverage
 ```
 
@@ -163,6 +165,7 @@ composer format:check
 - Use Pest PHP syntax (not PHPUnit)
 - Group integration tests with `->group('integration')`
 - Use `TestHelper::safeDisconnect()` in `finally` blocks for integration tests
+- **Code coverage must remain >= 99.5%.** Run `php -d pcov.enabled=1 ./vendor/bin/pest --coverage` and verify the total before submitting. Pull requests that drop coverage below this threshold will not be merged
 
 ### Commits
 

README.md

@@ -278,6 +278,20 @@ opcua-cli read opc.tcp://localhost:4840 "i=2259" --debug-file=/tmp/opcua.log --j
 | **`php-opcua/opcua-cli`** | **CLI tool (this package)** |
 | [`php-opcua/opcua-client-nodeset`](https://github.com/php-opcua/opcua-client-nodeset) | Pre-built NodeSet2 types for 51 OPC UA companion specifications |
 
+## Testing
+
+The project includes 272 tests (253 unit + 19 integration) with 592 assertions and **99.9% code coverage**.
+
+```bash
+# Run all tests
+./vendor/bin/pest
+
+# Run with coverage report (requires pcov)
+php -d pcov.enabled=1 ./vendor/bin/pest --coverage
+```
+
+Code coverage must remain >= 99.5%. See [CONTRIBUTING.md](CONTRIBUTING.md) for details.
+
 ## Requirements
 
 - PHP >= 8.2

ROADMAP.md

@@ -12,6 +12,7 @@
 - [x] NodeSet2.xml code generator: typed DTOs, PHP enums, binary codecs, registrar
 - [x] Server address space dump to NodeSet2.xml
 - [x] Server certificate trust management from the terminal
+- [x] **272 tests** (253 unit + 19 integration), 592 assertions, 99.9% code coverage
 
 ## Planned
 

composer.json

@@ -5,7 +5,7 @@
   "support": {
     "issues": "https://github.com/php-opcua/opcua-cli/issues",
     "source": "https://github.com/php-opcua/opcua-cli",
-    "docs": "https://github.com/php-opcua/opcua-client/tree/master/doc"
+    "docs": "https://github.com/php-opcua/opcua-cli/tree/master/doc"
   },
   "type": "library",
   "bin": [
@@ -44,7 +44,7 @@
   ],
   "require": {
     "php": "^8.2",
-    "php-opcua/opcua-client": "@dev"
+    "php-opcua/opcua-client": "^4.0"
   },
   "require-dev": {
     "pestphp/pest": "^3.0",

llms-full.txt

@@ -444,6 +444,30 @@ The dump output can be fed directly into generate:nodeset for end-to-end code ge
 
 ---
 
+## 8. Testing
+
+272 tests (253 unit + 19 integration), 592 assertions, 99.9% code coverage. Code coverage must remain >= 99.5% on every pull request.
+
+Tests use [Pest PHP](https://pestphp.com/) and [pcov](https://github.com/krakjoe/pcov) for coverage.
+
+```bash
+# All tests
+./vendor/bin/pest
+
+# Unit tests only
+./vendor/bin/pest tests/Unit/
+
+# Integration tests (requires opcua-test-suite running)
+./vendor/bin/pest tests/Integration/ --group=integration
+
+# With coverage report
+php -d pcov.enabled=1 ./vendor/bin/pest --coverage
+```
+
+Unit tests mock the OPC UA client via `PhpOpcua\Client\Testing\MockClient`. Integration tests connect to the [opcua-test-suite](https://github.com/php-opcua/opcua-test-suite) Docker containers.
+
+---
+
 ## Related Packages
 
 - php-opcua/opcua-client: pure PHP OPC UA client library — the foundation this CLI is built on

llms.txt

@@ -168,6 +168,15 @@ Options: --trust-store=PATH, --trust-policy=POLICY (fingerprint, fingerprint+exp
 - php-opcua/laravel-opcua: Laravel integration
 - php-opcua/opcua-session-manager: session persistence across PHP requests
 
+## Testing
+
+272 tests (253 unit + 19 integration), 592 assertions, 99.9% code coverage. Coverage must remain >= 99.5%.
+
+```
+./vendor/bin/pest
+php -d pcov.enabled=1 ./vendor/bin/pest --coverage
+```
+
 ## Requirements
 
 - PHP >= 8.2

src/Application.php

@@ -117,26 +117,48 @@ public function run(array $argv): int
 
             return $exitCode;
         } catch (UntrustedCertificateException $e) {
-            $output->error('Error: Server certificate not trusted.');
-            $output->error('  Fingerprint: ' . $e->fingerprint);
-            $output->writeln('');
-            $output->writeln('To trust this certificate, run:');
-            $output->writeln('  opcua-cli trust ' . ($parsed['arguments'][0] ?? '<endpoint>'));
-            $output->writeln('');
-            $output->writeln('To list trusted certificates:');
-            $output->writeln('  opcua-cli trust:list');
-            $output->writeln('');
-            $output->writeln('To skip trust validation for this command:');
-            $output->writeln('  opcua-cli ' . ($parsed['command'] ?? '') . ' ... --no-trust-policy');
-
-            return 1;
+            return $this->handleUntrustedCertificate($e, $output, $parsed['arguments'][0] ?? '<endpoint>', $parsed['command'] ?? '');
         } catch (OpcUaException $e) {
-            $output->error('Error: ' . $e->getMessage());
-
-            return 1;
+            return $this->handleOpcUaException($e, $output);
         }
     }
 
+    /**
+     * @param UntrustedCertificateException $e
+     * @param OutputInterface $output
+     * @param string $endpointUrl
+     * @param string $commandName
+     * @return int
+     */
+    public function handleUntrustedCertificate(UntrustedCertificateException $e, OutputInterface $output, string $endpointUrl, string $commandName): int
+    {
+        $output->error('Error: Server certificate not trusted.');
+        $output->error('  Fingerprint: ' . $e->fingerprint);
+        $output->writeln('');
+        $output->writeln('To trust this certificate, run:');
+        $output->writeln('  opcua-cli trust ' . $endpointUrl);
+        $output->writeln('');
+        $output->writeln('To list trusted certificates:');
+        $output->writeln('  opcua-cli trust:list');
+        $output->writeln('');
+        $output->writeln('To skip trust validation for this command:');
+        $output->writeln('  opcua-cli ' . $commandName . ' ... --no-trust-policy');
+
+        return 1;
+    }
+
+    /**
+     * @param OpcUaException $e
+     * @param OutputInterface $output
+     * @return int
+     */
+    public function handleOpcUaException(OpcUaException $e, OutputInterface $output): int
+    {
+        $output->error('Error: ' . $e->getMessage());
+
+        return 1;
+    }
+
     /**
      * @param array<string, string|bool> $options
      * @return OutputInterface

src/Commands/DumpNodesetCommand.php

@@ -271,7 +271,7 @@ private function readNodeAttributes(OpcUaClientInterface $client, NodeId $nodeId
      * @param NodeId $nodeId
      * @return ?array
      */
-    private function readDataTypeDefinition(OpcUaClientInterface $client, NodeId $nodeId): ?array
+    public function readDataTypeDefinition(OpcUaClientInterface $client, NodeId $nodeId): ?array
     {
         try {
             $dv = $client->read($nodeId, AttributeId::DataTypeDefinition);
@@ -301,7 +301,7 @@ private function readDataTypeDefinition(OpcUaClientInterface $client, NodeId $no
      * @param NodeId $nodeId
      * @return ?array
      */
-    private function findDefinitionFromDiscovery(OpcUaClientInterface $client, NodeId $nodeId): ?array
+    public function findDefinitionFromDiscovery(OpcUaClientInterface $client, NodeId $nodeId): ?array
     {
         try {
             $refs = $client->browseAll($nodeId);
@@ -450,7 +450,7 @@ private function structureDefinitionToArray(\PhpOpcua\Client\Types\StructureDefi
      * @param \PhpOpcua\Client\Encoding\BinaryDecoder $decoder
      * @return ?array
      */
-    private function parseRawDefinition(\PhpOpcua\Client\Encoding\BinaryDecoder $decoder): ?array
+    public function parseRawDefinition(\PhpOpcua\Client\Encoding\BinaryDecoder $decoder): ?array
     {
         try {
             $parsed = \PhpOpcua\Client\Encoding\StructureDefinitionParser::parse($decoder);

src/Commands/WatchCommand.php

@@ -101,7 +101,7 @@ private function watchPolling(OpcUaClientInterface $client, string $nodeIdStr, i
             if ($this->maxIterations !== null) {
                 continue;
             }
-            usleep($intervalMs * 1000);
+            $this->sleep($intervalMs * 1000);
         }
 
         return 0;
@@ -146,6 +146,15 @@ private function watchSubscription(OpcUaClientInterface $client, string $nodeIdS
         return 0;
     }
 
+    /**
+     * @param int $microseconds
+     * @return void
+     */
+    protected function sleep(int $microseconds): void
+    {
+        usleep($microseconds);
+    }
+
     /**
      * @param mixed $value
      * @return string