-
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
When running the latest version of phlex-markdown with the latest version of phlex, then there is the following deprecation warning output:
⚠️ [DEPRECATION] Defining the `template` method on a Phlex component will not be supported in Phlex 2.0. Please rename the method to `view_template` instead.
Because phlex-markdown still uses the deprecated template method name at
phlex-markdown/lib/phlex/markdown.rb
Line 12 in ee1e276
| def template |
I am happy to open a PR to fix the issue but would need some guideline on how you would like to handle updating the method name and handling compatibility between the new version of phlex-markdown and different versions of phlex. Just change the dependency in phlex-markdown.gemspec to spec.add_dependency "phlex", ">= 1.10"?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels