Skip to content

Commit ea2336a

Browse files
petercorkeclaude
andcommitted
ci: install graphviz in unittest/codecov jobs
test_dotfile() exercises the real dot->PDF rendering path via showgraph(), but only the docs job installed graphviz -- unittest and codecov didn't, so `dot` was silently missing there. The previous version of this test had no assertion on the result, so this went unnoticed; the new assertion (mock_open.assert_called_once(), added in this same PR) correctly caught it: CI failed with "dot: not found", showgraph()'s subprocess call returned nonzero, and webbrowser.open() was consequently never reached. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent af31c62 commit ea2336a

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ jobs:
2222
run: |
2323
python -m pip install --upgrade pip
2424
pip install .[dev]
25+
sudo apt-get update
26+
sudo apt-get install -y graphviz
2527
- name: Test with pytest
2628
run: pytest
2729

@@ -59,6 +61,8 @@ jobs:
5961
run: |
6062
python -m pip install --upgrade pip
6163
pip install -e .[dev]
64+
sudo apt-get update
65+
sudo apt-get install -y graphviz
6266
- name: Run coverage
6367
run: |
6468
pytest --cov=pgraph --cov-report=xml:coverage.xml

0 commit comments

Comments
 (0)