Introduce hint-device#916
Open
JamesPiechota wants to merge 7 commits into
Open
Conversation
JamesPiechota
force-pushed
the
fix/bundler-corruption-20260518
branch
5 times, most recently
from
6194048 to
b314aa5
Compare
JamesPiechota
force-pushed
the
fix/bundler-corruption-20260518
branch
2 times, most recently
from
fd5a398 to
3201c25
Compare
When converting from structured to a target codec, the target codec is provided as a hint to dev_structured and informs how dev_structured loads or unloads children as it recurses through dev_structured:from. This prevents bugs where a message could end up in a load state that does not match its commitments. This change also adds similar functionality to verify/id/commit.
Add dev_message_bundle_test_vectors: a battery exercising the `bundle'/`hint-device' machinery over a three-level signed message tree. For every 3x3x3 permutation of per-level bundle flags (true / false / none) it checks verify/3, id/3 and convert/4 -- the per-node path always verifies, a forced request bundle is harmless, and a converted tree's load state matches what was requested. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JamesPiechota
force-pushed
the
fix/bundler-corruption-20260518
branch
from
3201c25 to
47c7c49
Compare
JamesPiechota
force-pushed
the
fix/bundler-corruption-20260518
branch
from
f419dec to
751e148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bundler corruption that occurs when a user posts a nested dataitem containining
bundle=false. This change introduce ahint-devicerequest parameter that allows thestructuredcodec to delegate to the target codec the question of whether to bundle a given message or not.