From 9083ebe203e7f5f5c5373d26500daa4c639cedf4 Mon Sep 17 00:00:00 2001 From: nsheff Date: Thu, 5 Mar 2026 21:37:27 -0500 Subject: [PATCH 1/2] Remove logmuse.init_logger from __init__.py Calling init_logger at import time prevents the logger from inheriting configuration from a root logger, breaking logging when geofetch is used as a library. Use logging.getLogger() instead for the coloredlogs handler. --- geofetch/__init__.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/geofetch/__init__.py b/geofetch/__init__.py index e1b75f9..86527fe 100644 --- a/geofetch/__init__.py +++ b/geofetch/__init__.py @@ -1,7 +1,8 @@ """Package-level data""" +import logging + import coloredlogs -import logmuse from geofetch._version import __version__ from geofetch.finder import Finder @@ -10,7 +11,7 @@ __author__ = ["Oleksandr Khoroshevskyi", "Vince Reuter", "Nathan Sheffield"] __all__ = ["Finder", "Geofetcher", "__version__"] -_LOGGER = logmuse.init_logger("geofetch") +_LOGGER = logging.getLogger("geofetch") coloredlogs.install( logger=_LOGGER, datefmt="%H:%M:%S", From dde51bf39b8dfa11576f5da3b01485dfb180ef1b Mon Sep 17 00:00:00 2001 From: nsheff Date: Thu, 5 Mar 2026 21:53:22 -0500 Subject: [PATCH 2/2] Remove coloredlogs dependency, use logmuse>=0.3.0 logmuse 0.3.0 auto-detects coloredlogs and applies colored output when available. No need for packages to call coloredlogs.install() directly. Also removes init_logger from __init__.py to avoid overriding root logger configuration. --- geofetch/__init__.py | 11 ----------- geofetch/finder.py | 6 ------ requirements/requirements-all.txt | 3 +-- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/geofetch/__init__.py b/geofetch/__init__.py index 86527fe..3be93ae 100644 --- a/geofetch/__init__.py +++ b/geofetch/__init__.py @@ -1,19 +1,8 @@ """Package-level data""" -import logging - -import coloredlogs - from geofetch._version import __version__ from geofetch.finder import Finder from geofetch.geofetch import Geofetcher __author__ = ["Oleksandr Khoroshevskyi", "Vince Reuter", "Nathan Sheffield"] __all__ = ["Finder", "Geofetcher", "__version__"] - -_LOGGER = logging.getLogger("geofetch") -coloredlogs.install( - logger=_LOGGER, - datefmt="%H:%M:%S", - fmt="[%(levelname)s] [%(asctime)s] %(message)s", -) diff --git a/geofetch/finder.py b/geofetch/finder.py index 587e1ae..084c922 100644 --- a/geofetch/finder.py +++ b/geofetch/finder.py @@ -3,7 +3,6 @@ import re from datetime import datetime, timedelta -import coloredlogs import requests import xmltodict @@ -19,11 +18,6 @@ __author__ = "Oleksandr Khoroshevskyi" _LOGGER = logging.getLogger("__name__") -coloredlogs.install( - logger=_LOGGER, - datefmt="%H:%M:%S", - fmt="[%(levelname)s] [%(asctime)s] %(message)s", -) class Finder: diff --git a/requirements/requirements-all.txt b/requirements/requirements-all.txt index 9440999..883dc5e 100644 --- a/requirements/requirements-all.txt +++ b/requirements/requirements-all.txt @@ -1,10 +1,9 @@ colorama>=0.3.9 -logmuse>=0.2.6 +logmuse>=0.3.0 ubiquerg>=0.6.2 requests>=2.28.1 xmltodict>=0.13.0 pandas>=1.5.3 peppy>=0.40.6 rich>=12.5.1 -coloredlogs>=15.0.1 piper>=0.14.4