update createIcon tests for new structure

Author: kmcfaul

packages/react-icons/src/__tests__/createIcon.test.tsx

@@ -1,32 +1,43 @@
 import { render, screen } from '@testing-library/react';
-import { createIcon } from '../createIcon';
+import { IconDefinition, CreateIconProps, createIcon, SVGPathObject } from '../createIcon';
 
-const iconDef = {
+const multiPathIcon: IconDefinition = {
   name: 'IconName',
   width: 10,
   height: 20,
-  svgPath: 'svgPath'
+  svgPathData: [
+    { path: 'svgPath1', className: 'class1' },
+    { path: 'svgPath2', className: 'class2' }
+  ],
+  svgClassName: 'test'
 };
 
-const iconDefWithArrayPath = {
+const singlePathIcon: IconDefinition = {
   name: 'IconName',
   width: 10,
   height: 20,
-  svgPath: [
-    { path: 'svgPath1', className: 'class1' },
-    { path: 'svgPath2', className: 'class2' }
-  ],
+  svgPathData: 'svgPath',
   svgClassName: 'test'
 };
 
+const iconDef: CreateIconProps = {
+  name: 'SinglePathIconName',
+  icon: singlePathIcon
+};
+
+const iconDefWithArrayPath: CreateIconProps = {
+  name: 'MultiPathIconName',
+  icon: multiPathIcon
+};
+
 const SVGIcon = createIcon(iconDef);
 const SVGArrayIcon = createIcon(iconDefWithArrayPath);
 
 test('sets correct viewBox', () => {
   render(<SVGIcon />);
   expect(screen.getByRole('img', { hidden: true })).toHaveAttribute(
     'viewBox',
-    `0 0 ${iconDef.width} ${iconDef.height}`
+    `0 0 ${singlePathIcon.width} ${singlePathIcon.height}`
   );
 });
 
@@ -39,16 +50,16 @@ test('sets correct svgPath if array', () => {
   render(<SVGArrayIcon />);
   const paths = screen.getByRole('img', { hidden: true }).querySelectorAll('path');
   expect(paths).toHaveLength(2);
-  expect(paths[0]).toHaveAttribute('d', iconDefWithArrayPath.svgPath[0].path);
-  expect(paths[1]).toHaveAttribute('d', iconDefWithArrayPath.svgPath[1].path);
-  expect(paths[0]).toHaveClass(iconDefWithArrayPath.svgPath[0].className);
-  expect(paths[1]).toHaveClass(iconDefWithArrayPath.svgPath[1].className);
+  expect(paths[0]).toHaveAttribute('d', (multiPathIcon.svgPathData as SVGPathObject[])[0].path);
+  expect(paths[1]).toHaveAttribute('d', (multiPathIcon.svgPathData as SVGPathObject[])[1].path);
+  expect(paths[0]).toHaveClass((multiPathIcon.svgPathData as SVGPathObject[])[0].className ?? '');
+  expect(paths[1]).toHaveClass((multiPathIcon.svgPathData as SVGPathObject[])[1].className ?? '');
 });
 
 test('sets correct svgClassName', () => {
   render(<SVGArrayIcon />);
   const paths = screen.getByRole('img', { hidden: true });
-  expect(paths).toHaveClass(iconDefWithArrayPath.svgClassName);
+  expect(paths).toHaveClass(multiPathIcon.svgClassName ?? '');
 });
 
 test('aria-hidden is true if no title is specified', () => {

packages/react-icons/src/createIcon.tsx

@@ -15,7 +15,7 @@ export interface IconDefinition {
   svgClassName?: string;
 }
 
-export interface CreateIconProps extends IconDefinition {
+export interface CreateIconProps {
   name?: string;
   icon?: IconDefinition;
   rhUiIcon?: IconDefinition | null;