Skip to content

Commit bc024ff

Browse files
thatblindgeyethatblindgeye
authored
chore(Drawer): unskip integration test (#12425)
* chore(Drawer): unskip integration test * Updated snapshots and drawer test
1 parent 9e88adf commit bc024ff

12 files changed

Lines changed: 65 additions & 64 deletions

File tree

‎packages/react-charts/src/victory/components/ChartBar/__snapshots__/ChartBar.test.tsx.snap‎

Lines changed: 24 additions & 24 deletions
Large diffs are not rendered by default.

‎packages/react-charts/src/victory/components/ChartBullet/__snapshots__/ChartBullet.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ A 0 0 0 0 1, 312.5, 85
380380
index="0"
381381
role="presentation"
382382
shape-rendering="auto"
383-
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
383+
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
384384
/>
385385
</g>
386386
<g
@@ -399,7 +399,7 @@ A 0 0 0 0 1, 225, 85
399399
index="0"
400400
role="presentation"
401401
shape-rendering="auto"
402-
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
402+
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
403403
/>
404404
</g>
405405
<g

‎packages/react-charts/src/victory/components/ChartBullet/__snapshots__/ChartBulletQualitativeRange.test.tsx.snap‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ A 0 0 0 0 1, 399.99999999976666, 104.8
8383
index="0"
8484
role="presentation"
8585
shape-rendering="auto"
86-
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--300, #c7c7c7); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
86+
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--300, #c7c7c7); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
8787
/>
8888
</g>
8989
<g
@@ -102,7 +102,7 @@ A 0 0 0 0 1, 399.9999999995882, 104.8
102102
index="0"
103103
role="presentation"
104104
shape-rendering="auto"
105-
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
105+
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--200, #e0e0e0); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
106106
/>
107107
</g>
108108
<g
@@ -121,7 +121,7 @@ A 0 0 0 0 1, 399.9999999993, 104.8
121121
index="0"
122122
role="presentation"
123123
shape-rendering="auto"
124-
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
124+
style="fill: var(--pf-v6-chart-bullet--qualitative-range--ColorScale--100, #f2f2f2); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); padding: 8px; stroke-width: var(--pf-v6-chart-bar--data-stroke--Width, 0px);"
125125
/>
126126
</g>
127127
</svg>

‎packages/react-charts/src/victory/components/ChartStack/__snapshots__/ChartStack.test.tsx.snap‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ A 0 0 0 0 1, 85, 125.86206896551724
8484
index="0"
8585
role="presentation"
8686
shape-rendering="auto"
87-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
87+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
8888
/>
8989
<path
9090
d="M 123.33333333333331, 125.86206896551724
@@ -99,7 +99,7 @@ A 0 0 0 0 1, 133.33333333333331, 125.86206896551724
9999
index="1"
100100
role="presentation"
101101
shape-rendering="auto"
102-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
102+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
103103
/>
104104
<path
105105
d="M 171.66666666666666, 77.58620689655172
@@ -114,7 +114,7 @@ A 0 0 0 0 1, 181.66666666666666, 77.58620689655172
114114
index="2"
115115
role="presentation"
116116
shape-rendering="auto"
117-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
117+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
118118
/>
119119
<path
120120
d="M 219.99999999999997, 101.72413793103448
@@ -129,7 +129,7 @@ A 0 0 0 0 1, 229.99999999999997, 101.72413793103448
129129
index="3"
130130
role="presentation"
131131
shape-rendering="auto"
132-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
132+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--400, #4394e5); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
133133
/>
134134
</g>
135135
<g
@@ -148,7 +148,7 @@ A 0 0 0 0 1, 85, 139.6551724137931
148148
index="0"
149149
role="presentation"
150150
shape-rendering="auto"
151-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
151+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
152152
/>
153153
<path
154154
d="M 123.33333333333331, 139.6551724137931
@@ -163,7 +163,7 @@ A 0 0 0 0 1, 133.33333333333331, 139.6551724137931
163163
index="1"
164164
role="presentation"
165165
shape-rendering="auto"
166-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
166+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
167167
/>
168168
<path
169169
d="M 171.66666666666666, 108.62068965517243
@@ -178,7 +178,7 @@ A 0 0 0 0 1, 181.66666666666666, 108.62068965517243
178178
index="2"
179179
role="presentation"
180180
shape-rendering="auto"
181-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
181+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
182182
/>
183183
<path
184184
d="M 219.99999999999997, 125.86206896551724
@@ -193,7 +193,7 @@ A 0 0 0 0 1, 229.99999999999997, 125.86206896551724
193193
index="3"
194194
role="presentation"
195195
shape-rendering="auto"
196-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
196+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--300, #003366); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
197197
/>
198198
</g>
199199
<g
@@ -212,7 +212,7 @@ A 0 0 0 0 1, 85, 146.55172413793105
212212
index="0"
213213
role="presentation"
214214
shape-rendering="auto"
215-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
215+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
216216
/>
217217
<path
218218
d="M 123.33333333333331, 143.10344827586206
@@ -227,7 +227,7 @@ A 0 0 0 0 1, 133.33333333333331, 143.10344827586206
227227
index="1"
228228
role="presentation"
229229
shape-rendering="auto"
230-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
230+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
231231
/>
232232
<path
233233
d="M 171.66666666666666, 132.75862068965517
@@ -242,7 +242,7 @@ A 0 0 0 0 1, 181.66666666666666, 132.75862068965517
242242
index="2"
243243
role="presentation"
244244
shape-rendering="auto"
245-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
245+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
246246
/>
247247
<path
248248
d="M 219.99999999999997, 139.6551724137931
@@ -257,7 +257,7 @@ A 0 0 0 0 1, 229.99999999999997, 139.6551724137931
257257
index="3"
258258
role="presentation"
259259
shape-rendering="auto"
260-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
260+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--200, #92c5f9); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
261261
/>
262262
</g>
263263
<g
@@ -276,7 +276,7 @@ A 0 0 0 0 1, 85, 150
276276
index="0"
277277
role="presentation"
278278
shape-rendering="auto"
279-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
279+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
280280
/>
281281
<path
282282
d="M 123.33333333333331, 150
@@ -291,7 +291,7 @@ A 0 0 0 0 1, 133.33333333333331, 150
291291
index="1"
292292
role="presentation"
293293
shape-rendering="auto"
294-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
294+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
295295
/>
296296
<path
297297
d="M 171.66666666666666, 150
@@ -306,7 +306,7 @@ A 0 0 0 0 1, 181.66666666666666, 150
306306
index="2"
307307
role="presentation"
308308
shape-rendering="auto"
309-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
309+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
310310
/>
311311
<path
312312
d="M 219.99999999999997, 150
@@ -321,7 +321,7 @@ A 0 0 0 0 1, 229.99999999999997, 150
321321
index="3"
322322
role="presentation"
323323
shape-rendering="auto"
324-
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, rgba(255, 255, 255, 0.0000)); stroke-width: 1; padding: 8px;"
324+
style="fill: var(--pf-v6-chart-theme--blue--ColorScale--100, #0066cc); stroke: var(--pf-v6-chart-bar--data--stroke, #ffffff); stroke-width: 1; padding: 8px;"
325325
/>
326326
</g>
327327
</g>

‎packages/react-core/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"tslib": "^2.8.1"
5555
},
5656
"devDependencies": {
57-
"@patternfly/patternfly": "6.5.0-prerelease.88",
57+
"@patternfly/patternfly": "6.5.0-prerelease.91",
5858
"case-anything": "^3.1.2",
5959
"css": "^3.0.0",
6060
"fs-extra": "^11.3.3"

‎packages/react-docs/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"test:a11y": "patternfly-a11y --config patternfly-a11y.config"
2424
},
2525
"dependencies": {
26-
"@patternfly/patternfly": "6.5.0-prerelease.88",
26+
"@patternfly/patternfly": "6.5.0-prerelease.91",
2727
"@patternfly/react-charts": "workspace:^",
2828
"@patternfly/react-code-editor": "workspace:^",
2929
"@patternfly/react-core": "workspace:^",

‎packages/react-icons/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"@fortawesome/free-brands-svg-icons": "^5.15.4",
3636
"@fortawesome/free-regular-svg-icons": "^5.15.4",
3737
"@fortawesome/free-solid-svg-icons": "^5.15.4",
38-
"@patternfly/patternfly": "6.5.0-prerelease.88",
38+
"@patternfly/patternfly": "6.5.0-prerelease.91",
3939
"@rhds/icons": "^2.2.0",
4040
"fs-extra": "^11.3.3",
4141
"tslib": "^2.8.1"

‎packages/react-integration/cypress/downloads/downloads.html‎

-116 KB
Binary file not shown.

‎packages/react-integration/cypress/integration/drawer.spec.ts‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
const visitDrawerDemoWithGlassTheme = () => {
1+
const visitDrawerDemoWithGlassTheme = (viewportWidth: number = 1280) => {
22
cy.visit('http://localhost:3000/drawer-demo-nav-link');
3-
cy.viewport(1280, 800);
3+
cy.viewport(viewportWidth, 800);
44
cy.document().then((doc) => {
55
doc.documentElement.classList.add('pf-v6-theme-glass');
66
});
@@ -129,9 +129,10 @@ describe('Drawer Demo Test', () => {
129129
});
130130
});
131131

132-
// Blocked on Core: https://github.com/patternfly/patternfly/issues/8340
133-
it.skip('glass theme: drawer panel has no glass CSS when isGlass is false', () => {
134-
visitDrawerDemoWithGlassTheme();
132+
// We only want to test at mobile viewport for this, as at desktop a drawer panel should correclty have
133+
// a transprent (or rgba(0,0,0,0)) background, which incorrectly triggers a failure here.
134+
it('glass theme: drawer panel has no glass CSS when isGlass is false', () => {
135+
visitDrawerDemoWithGlassTheme(700);
135136

136137
cy.get('#drawer-glass-theme-no-isglass.pf-v6-c-drawer').should(($drawer) => {
137138
expect($drawer).to.have.length(1);

‎packages/react-styles/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"clean": "rimraf dist css"
2020
},
2121
"devDependencies": {
22-
"@patternfly/patternfly": "6.5.0-prerelease.88",
22+
"@patternfly/patternfly": "6.5.0-prerelease.91",
2323
"change-case": "^5.4.4",
2424
"fs-extra": "^11.3.3"
2525
},

0 commit comments

Comments
 (0)