test(LoginPage): enhance brand image tests with aria-label and className attributes

Signed-off-by: Mohamed Fall <ps.hackmaster@gmail.com>

Author: fallmo

packages/react-core/src/components/LoginPage/__tests__/LoginPage.test.tsx

@@ -1,5 +1,5 @@
 import { Fragment } from 'react';
-import { render } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
 
 import { LoginPage } from '../LoginPage';
 import { ListVariant } from '../../List';
@@ -38,8 +38,28 @@ test('brand is present with brandImgSrc prop', () => {
 });
 
 test('brandImgProps successfully renders brand with props', () => {
-  const { asFragment } = render(
-    <LoginPage brandImgProps={{ src: 'Brand src', alt: 'Pf-logo' }} loginTitle="Log into your account" />
+  render(
+    <LoginPage
+      brandImgProps={{ src: 'Brand src', alt: 'Pf-logo', 'aria-label': 'PatternFly logo', className: 'custom-class' }}
+      loginTitle="Log into your account"
+    />
   );
-  expect(asFragment()).toMatchSnapshot();
+  const brandImg = screen.getByRole('img', { name: 'PatternFly logo' });
+  expect(brandImg).toHaveAttribute('src', 'Brand src');
+  expect(brandImg).toHaveAttribute('alt', 'Pf-logo');
+  expect(brandImg).toHaveAttribute('aria-label', 'PatternFly logo');
+  expect(brandImg).toHaveClass('custom-class');
+});
+
+test('Brand is rendered correctly with both brandImgSrc and brandImgProps, prioritizing brandImgProps.src', () => {
+  render(
+    <LoginPage
+      brandImgSrc="Brand-src-that-should-be-ignored"
+      brandImgProps={{ src: 'Brand-src-from-props', alt: 'Pf-logo from props' }}
+      loginTitle="Log into your account"
+    />
+  );
+  const brandImg = screen.getByRole('img', { name: 'Pf-logo from props' });
+  expect(brandImg).toHaveAttribute('src', 'Brand-src-from-props');
+  expect(brandImg).toHaveAttribute('alt', 'Pf-logo from props');
 });

packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginPage.test.tsx.snap

@@ -92,55 +92,6 @@ exports[`brand is present with brandImgSrc prop 1`] = `
 </DocumentFragment>
 `;
 
-exports[`brandImgProps successfully renders brand with props 1`] = `
-<DocumentFragment>
-  <div
-    class="pf-v6-c-login"
-  >
-    <div
-      class="pf-v6-c-login__container"
-    >
-      <header
-        class="pf-v6-c-login__header"
-      >
-        <img
-          alt="Pf-logo"
-          class="pf-v6-c-brand"
-          src="Brand src"
-        />
-      </header>
-      <main
-        class="pf-v6-c-login__main"
-      >
-        <div
-          class="pf-v6-c-login__main-header"
-        >
-          <h2
-            class="pf-v6-c-title pf-m-3xl"
-            data-ouia-component-id="OUIA-Generated-Title-4"
-            data-ouia-component-type="PF6/Title"
-            data-ouia-safe="true"
-          >
-            Log into your account
-          </h2>
-        </div>
-        <div
-          class="pf-v6-c-login__main-body"
-        />
-      </main>
-      <footer
-        class="pf-v6-c-login__footer"
-      >
-        <p />
-        <ul
-          class="pf-v6-c-list"
-        />
-      </footer>
-    </div>
-  </div>
-</DocumentFragment>
-`;
-
 exports[`check loginpage example against snapshot 1`] = `
 <DocumentFragment>
   <div