Commit 5058508
committed
fix(DragDropSort): support custom drag button aria-label and fix falsy id overlay
Adds a `dragButtonAriaLabel` prop to `Draggable` that forwards to
`DragButton`, allowing consumers to provide a translated accessible
name for the drag handle via `DraggableObject.props`.
Also fixes `DragDropContainer` rendering the literal text "0" as the
drag overlay when a draggable item has a falsy numeric id (e.g. `0`).
The `activeId && getDragOverlay()` expression short-circuits to `0`
which React renders as text. Changed to `activeId != null`.1 parent 6b93dbd commit 5058508
2 files changed
Lines changed: 6 additions & 3 deletions
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
243 | | - | |
| 243 | + | |
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
| |||
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
293 | | - | |
| 293 | + | |
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| 25 | + | |
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
| |||
38 | 41 | | |
39 | 42 | | |
40 | 43 | | |
41 | | - | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
0 commit comments