Inline popup should show when relevant fields get focus

[max-baz]

Right now inline popup only shows up if you click inside the relevant field, like username or password.
If the field is auto-focused when page is loaded, or if you focus on the field using Tab key, the inline popup doesn't show up.

To reproduce, open https://github.com/login - the username field has focus, but inline popup doesn't show. Press Tab, bringing the focus into the password field - the inline popup still doesn't show up.

[erayd]

Testing on this is proving frustrating; the behaviour is conflicting with the 'tab to enter popup' behaviour. If the popup appears on focus, then the user cannot tab to the next field without first entering and then closing the popup.

@max-baz Do you have any suggestions on how to resolve this? I can't think of a sane way to do it without either breaking that feature or really annoying the user.

[max-baz]

Is this only an issue when you want to skip the field? Because if you want to fill in the field, you either start typing yourself (which will auto-close the popup), or you will anyway Tab into the popup in order to choose the password entry to use. If you want to skip the field, then yes, a Tab will jump into the popup first, and then you need to close it in order to continue jumping. But do you think this will be a frequent occurrence?

[erayd]

Yep, only when skipping the field.

I don't know how common an occurrence this would be, but my instinct is common enough that we need to care about it. Especially when tabbing across already-filled fields.

[erayd]

What if the on-focus event did nothing, but we provided another hotkey to open the context popup on the focused field? It's an extra step, but would resolve the conflict.

[max-baz]

It's difficult to say what we will end up doing more frequently, using this new hotkey to open the popup, or occasionally having to dismiss the popup with an Esc when we are skipping a field, and then continuing with Tab as intended 🤔

[erayd]

How many users will know that they can press escape, to close it? Even once documented, many will not read it. Also, needing to do that across multiple fields is also annoying 😉

How frequently do you focus a field and want the context popup?

[max-baz]

I will try to pay attention to this in the coming days and report :) The initial motivation for this ticket was github.com/login - when I open the page, the login field already has focus, so I would have expected to already see the popup, since I'm asked to fill this field.

[erayd]

Would making the normal toolbar popup give first priority to the currently-focused field on the page address this need?

[max-baz]

To be honest this also crossed my mind when you mentioned a second hotkey - we could instead make our existing shortcut (that opens the toolbar popup) better guess what field I want to fill, by taking into account the last cursor position. Don't know if it addresses this need, but it's a good idea regardless!

[erayd]

I think this may also need to be gated behind an option. I'm finding the auto-show of the context popup really annoying on websites that I have no intention of logging into, but it's finding and appearing for login fields on those pages regardless.

[max-baz]

Do we even need this inline popup at all, especially if the toolbar popup will take the focused field into account? Just asking 😁

[erayd]

Do we even need this inline popup at all, especially if the toolbar popup will take the focused field into account? Just asking 😁

Definitely. It's something that I use constantly, is actually the more secure option (because you know which field it'll fill), and a feature that is commonly available in other password managers (i.e. the behavioural consistency in the UI is useful).