From 07f1f436007407dacb9f2c24f4a209073814e25d Mon Sep 17 00:00:00 2001 From: Christian Berendt Date: Sat, 27 Jun 2026 20:25:49 +0200 Subject: [PATCH] Drop setuptools as a direct runtime dependency setuptools was listed as a direct runtime dependency in requirements.txt and Pipfile (#863), but the project itself does not import setuptools or pkg_resources at runtime (version detection uses importlib.metadata in openstack_image_manager/__init__.py). setuptools is still pulled in transitively as a runtime dependency of pbr (openstacksdk -> keystoneauth1/os-service-types -> pbr), so it remains installed; only the redundant direct pin is removed. The original rationale (providing pkg_resources under Python 3.12+) no longer applies anyway, since setuptools removed pkg_resources in v81. Pipfile.lock is regenerated: setuptools stays as a transitive dependency (==82.0.1) with no package version changes. Closes #1234 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christian Berendt --- Pipfile | 1 - Pipfile.lock | 3 +-- requirements.txt | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/Pipfile b/Pipfile index 20c633e4..8f24ef6e 100644 --- a/Pipfile +++ b/Pipfile @@ -16,4 +16,3 @@ requests = "==2.34.2" tabulate = "==0.10.0" typer = {extras = ["all"], version = "==0.26.7"} yamale = "==6.1.0" -setuptools = "==82.0.1" diff --git a/Pipfile.lock b/Pipfile.lock index 7cb21270..eb11102a 100644 --- a/Pipfile.lock +++ b/Pipfile.lock @@ -1,7 +1,7 @@ { "_meta": { "hash": { - "sha256": "bd0bf81b10e9cf1340d22509cacd6c433f68b88912598f474d68318c7fe73676" + "sha256": "bbb2fa2fe0b0b7c1b15dce157c33c3202bce95593bb6f77c5664ec6c034ccf1e" }, "pipfile-spec": 6, "requires": {}, @@ -828,7 +828,6 @@ "sha256:7d872682c5d01cfde07da7bccc7b65469d3dca203318515ada1de5eda35efbf9", "sha256:a59e362652f08dcd477c78bb6e7bd9d80a7995bc73ce773050228a348ce2e5bb" ], - "index": "pypi", "markers": "python_version >= '3.9'", "version": "==82.0.1" }, diff --git a/requirements.txt b/requirements.txt index ae60a82f..5a3c4bf7 100644 --- a/requirements.txt +++ b/requirements.txt @@ -7,7 +7,6 @@ paramiko==5.0.0 patool==4.0.5 requests==2.34.2 ruamel.yaml==0.19.1 -setuptools==82.0.1 tabulate==0.10.0 typer[all]==0.26.7 yamale==6.1.0