In the case of JS codegen primes are not escaped on the foreign module side. It also seems that current escaping strategy is a bit unsafe (it is possible to introduce name collisions I think). How do we want to approach this:
-
Do we want to use bracket notation like it is done in the current official purs codegen and avoid escaping foreign identifiers (here I have a hot fix - is it worth a PR)?
-
Do we want to leave it for now and wait for the future purs release?
P.S.I.
I'm using this trivial test script to test psimp codegen on itself.
P.S.II.
After applying the fix I'm getting different errors which we can discuss later when we overcome the first issue ;-)
In the case of JS codegen primes are not escaped on the foreign module side. It also seems that current escaping strategy is a bit unsafe (it is possible to introduce name collisions I think). How do we want to approach this:
Do we want to use bracket notation like it is done in the current official purs codegen and avoid escaping foreign identifiers (here I have a hot fix - is it worth a PR)?
Do we want to leave it for now and wait for the future purs release?
P.S.I.
I'm using this trivial test script to test psimp codegen on itself.
P.S.II.
After applying the fix I'm getting different errors which we can discuss later when we overcome the first issue ;-)