From a32c3826cace8f00e50c32d39587d69f5a047ae8 Mon Sep 17 00:00:00 2001 From: Muzahidul Islam Date: Wed, 14 Oct 2026 19:08:40 +0600 Subject: [PATCH] fix: forward options in async fetchQualifiedSegments The async overload called the completion-handler form without passing `options`, so .ignoreCache and .resetCache were silently ignored. Co-Authored-By: Claude Opus 5.5 --- Sources/Optimizely+Decide/OptimizelyUserContext.swift | 2 +- .../OptimizelyUserContextTests_ODP_Aync_Await.swift | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Sources/Optimizely+Decide/OptimizelyUserContext.swift b/Sources/Optimizely+Decide/OptimizelyUserContext.swift index 70959baf..d42cf518 100644 --- a/Sources/Optimizely+Decide/OptimizelyUserContext.swift +++ b/Sources/Optimizely+Decide/OptimizelyUserContext.swift @@ -340,7 +340,7 @@ extension OptimizelyUserContext { @available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *) public func fetchQualifiedSegments(options: [OptimizelySegmentOption] = []) async throws { return try await withCheckedThrowingContinuation { continuation in - fetchQualifiedSegments { error in + fetchQualifiedSegments(options: options) { error in if let error = error { continuation.resume(throwing: error) } else { diff --git a/Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP_Aync_Await.swift b/Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP_Aync_Await.swift index 4b6e9677..671735ed 100644 --- a/Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP_Aync_Await.swift +++ b/Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ODP_Aync_Await.swift @@ -53,7 +53,15 @@ final class OptimizelyUserContextTests_ODP_Aync_Await: XCTestCase { XCTAssertNil(_error) XCTAssertEqual(self.user.qualifiedSegments, ["odp-segment-1"]) } - + + func testFetchQualifiedSegments_optionsForwarded() async throws { + try? optimizely.start(datafile: datafile) + user = optimizely.createUserContext(userId: kUserId) + + try await user.fetchQualifiedSegments(options: [.ignoreCache, .resetCache]) + XCTAssertEqual([.ignoreCache, .resetCache], odpManager.options) + } + // MARK: - Failure func testFetchQualifiedSegments_sdkNotReady() async throws {