From ea56f04be57f49c8b5f9b1235a0a7243f01be76c Mon Sep 17 00:00:00 2001 From: xavier Date: Tue, 2 Jun 2026 12:11:04 -0400 Subject: [PATCH 1/2] Add risk level rubric to AGENTS.md --- AGENTS.md | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/AGENTS.md b/AGENTS.md index 72e567d46..6b76a2e3a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -153,6 +153,40 @@ When finishing a development branch: 3. Push to the contributor's fork remote (not `origin`) 4. Create the PR against `origin/main` using `--head :` +## Risk Levels + +When creating Jira tickets for this repo, assign a risk level in the description. + +| Level | Customer Impact | Review Requirements | Automation | +|-------|----------------|---------------------|------------| +| Risk 1 | Very little impact if change goes wrong | No human code review required | Fully automated implementation | +| Risk 2 | Medium impact if change causes problems | 1 human reviewer required | Automated implementation with human review gate | +| Risk 3 | Major impact — risk of losing customers if a bug is introduced | 2+ human reviewers required | Human-driven implementation | + +### Classification Examples + +| Change Type | Risk Level | +|-------------|------------| +| Dependency version bump | 1 | +| Doc/comment updates, test-only changes | 1 | +| Internal refactor with no API change | 2 | +| New provider adapter | 2 | +| RAG pipeline changes | 2 | +| API contract changes (endpoints, request/response schemas) | 3 | +| Authentication/authorization changes | 3 | +| LLM prompt template changes affecting user-facing responses | 3 | + +### Jira Description Format + +Include this section in every ticket description: + +``` +## Risk Level + +Risk {1|2|3} — {one-line impact summary} +Rationale: {why this classification, referencing the rubric} +``` + ## Maintaining This Guide Update this file and the relevant `docs/ai/` reference when patterns, tooling, or conventions change, or after repeated mistakes. Only document what you would get wrong without being told — remove anything inferable from reading the code. From 8f3ff71052a612954530a082b2b2ed85d258e906 Mon Sep 17 00:00:00 2001 From: xavier Date: Tue, 2 Jun 2026 17:53:16 -0400 Subject: [PATCH 2/2] =?UTF-8?q?Simplify=20risk=20levels=20to=20pointer=20?= =?UTF-8?q?=E2=80=94=20rubric=20enforced=20via=20hook?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- AGENTS.md | 32 +------------------------------- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 6b76a2e3a..02a70787a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -155,37 +155,7 @@ When finishing a development branch: ## Risk Levels -When creating Jira tickets for this repo, assign a risk level in the description. - -| Level | Customer Impact | Review Requirements | Automation | -|-------|----------------|---------------------|------------| -| Risk 1 | Very little impact if change goes wrong | No human code review required | Fully automated implementation | -| Risk 2 | Medium impact if change causes problems | 1 human reviewer required | Automated implementation with human review gate | -| Risk 3 | Major impact — risk of losing customers if a bug is introduced | 2+ human reviewers required | Human-driven implementation | - -### Classification Examples - -| Change Type | Risk Level | -|-------------|------------| -| Dependency version bump | 1 | -| Doc/comment updates, test-only changes | 1 | -| Internal refactor with no API change | 2 | -| New provider adapter | 2 | -| RAG pipeline changes | 2 | -| API contract changes (endpoints, request/response schemas) | 3 | -| Authentication/authorization changes | 3 | -| LLM prompt template changes affecting user-facing responses | 3 | - -### Jira Description Format - -Include this section in every ticket description: - -``` -## Risk Level - -Risk {1|2|3} — {one-line impact summary} -Rationale: {why this classification, referencing the rubric} -``` +Risk levels are enforced via a PreToolUse hook before every Jira create/edit call. The rubric and classification examples live in [lightspeed-team-harness/hooks/risk-rubric.md](https://github.com/openshift/lightspeed-team-harness/blob/main/hooks/risk-rubric.md). ## Maintaining This Guide