OCPBUGS-87234: Updating ingress-node-firewall-operator-container image to be consistent with ART for 5.0#716
Conversation
|
Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/201 |
WalkthroughCI and container build infrastructure are updated to OpenShift 5.0 with Go 1.26. The release image tag in ChangesBuild and Runtime Infrastructure Update
🎯 1 (Trivial) | ⏱️ ~3 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87234, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Dockerfile.openshift (1)
21-26:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Missing USER directive and HEALTHCHECK violate container security guidelines.
The final runtime stage runs as root and has no health monitoring. While these are pre-existing issues (not introduced by this version bump), the container security guidelines explicitly require:
- USER non-root: A non-root USER directive must be set. Running as root violates the "never run as root" requirement.
- HEALTHCHECK defined: A HEALTHCHECK directive is required to monitor container health.
🛡️ Proposed fix to add USER and HEALTHCHECK
FROM registry.ci.openshift.org/ocp/5.0:base-rhel9 WORKDIR / +USER 65532:65532 COPY --from=builder /workspace/manager . COPY --from=builder /workspace/bindata/manifests /bindata/manifests +HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \ + CMD ["/manager", "--health-check"] || exit 1 + ENTRYPOINT ["/manager"]Note: Adjust the USER ID and HEALTHCHECK command to match your application's requirements. Ensure the manager binary supports a health check endpoint or flag.
As per coding guidelines: "USER non-root; never run as root" and "HEALTHCHECK defined" (Container security prodsec-skills).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile.openshift` around lines 21 - 26, The final stage in Dockerfile.openshift leaves the container running as root and lacks a HEALTHCHECK; update the final runtime stage that contains ENTRYPOINT ["/manager"] to switch to a non-root user and add a HEALTHCHECK instruction. Create or switch to a dedicated unprivileged user (e.g., add a USER with a specific non-root UID/GID or use an existing unprivileged user) and ensure file permissions allow /manager execution by that user, then add a HEALTHCHECK that probes the manager process (for example an HTTP/HTTPs endpoint, TCP port, or a simple command that validates /manager is responsive) with reasonable retries and intervals to satisfy container security guidelines. Ensure the USER and HEALTHCHECK are placed in the final stage (the stage that contains ENTRYPOINT ["/manager"]) so they apply at runtime.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Dockerfile.openshift`:
- Around line 21-26: The final stage in Dockerfile.openshift leaves the
container running as root and lacks a HEALTHCHECK; update the final runtime
stage that contains ENTRYPOINT ["/manager"] to switch to a non-root user and add
a HEALTHCHECK instruction. Create or switch to a dedicated unprivileged user
(e.g., add a USER with a specific non-root UID/GID or use an existing
unprivileged user) and ensure file permissions allow /manager execution by that
user, then add a HEALTHCHECK that probes the manager process (for example an
HTTP/HTTPs endpoint, TCP port, or a simple command that validates /manager is
responsive) with reasonable retries and intervals to satisfy container security
guidelines. Ensure the USER and HEALTHCHECK are placed in the final stage (the
stage that contains ENTRYPOINT ["/manager"]) so they apply at runtime.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4bc0487a-3719-4ab5-b384-835de6033870
📒 Files selected for processing (2)
.ci-operator.yamlDockerfile.openshift
|
@openshift-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87234, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
ART wants to connect issue OCPBUGS-87564 to this PR, but found it is currently hooked up to ['OCPBUGS-87234']. Please consult with #forum-ocp-art if it is not clear what there is to do. |
3 participants
Updating ingress-node-firewall-operator-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request:
ingress-node-firewall-operator.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team
in
#forum-ocp-arton Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
verify-depsis complaining. In that case, please opena new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
any required labels to ensure the PR merges once tests are passing. In cases where ART config is
canonical, downstream builds are already being built with these changes, and merging this PR
only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
a grace period for the component team to align their CI with ART's configuration before it becomes
canonical in product builds.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
To do so, open a PR to set the
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out in the
#forum-ocp-artSlack channel.