Skip to content

OCPBUGS-86869: Upgrades envtest Makefile target#715

Open
raphaelvrosa wants to merge 2 commits into
openshift:release-4.21from
raphaelvrosa:release-4.21
Open

OCPBUGS-86869: Upgrades envtest Makefile target#715
raphaelvrosa wants to merge 2 commits into
openshift:release-4.21from
raphaelvrosa:release-4.21

Conversation

@raphaelvrosa

@raphaelvrosa raphaelvrosa commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

- Sets it to use go install with 0.20.4 envtest version.
- Updates test Makefile targets to reflect changes in envtest
- Other changes come from `make test` call that automates the
updates of base CRD yamls.
- Updates failed test case: changed from TCP to UDP protocol, as
it appears the test was not being executed properly.

Signed-off-by: Raphael Rosa <raprosa@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1c57f970-57cd-4292-bc5b-024020efa441

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jcaamano and martinkennelly June 2, 2026 15:55
@openshift-ci

openshift-ci Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raphaelvrosa
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raphaelvrosa raphaelvrosa changed the title Upgrades envtest Makefile target OCPBUGS-86869: Upgrades envtest Makefile target Jun 2, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

  • expected the bug to target only the "4.21.z" version, but multiple target versions were set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-86869 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

  • Sets it to use go install with 0.20.4 envtest version.
  • Updates test Makefile targets to reflect changes in envtest
  • Other changes come from make test call that automates the updates of base CRD yamls.
  • Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 2, 2026
@raphaelvrosa

Copy link
Copy Markdown
Contributor Author

/jira-refresh

@openshift-ci-robot

Copy link
Copy Markdown

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-86869 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

  • Sets it to use go install with 0.20.4 envtest version.
  • Updates test Makefile targets to reflect changes in envtest
  • Other changes come from make test call that automates the updates of base CRD yamls.
  • Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

Unblocks: #703

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raphaelvrosa

Copy link
Copy Markdown
Contributor Author

/jira-refresh

Signed-off-by: Raphael Rosa <raprosa@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@raphaelvrosa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@raphaelvrosa

Copy link
Copy Markdown
Contributor Author

@danwinship can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants