OCPBUGS-86869: Upgrades envtest Makefile target#715
Conversation
- Sets it to use go install with 0.20.4 envtest version. - Updates test Makefile targets to reflect changes in envtest - Other changes come from `make test` call that automates the updates of base CRD yamls. - Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly. Signed-off-by: Raphael Rosa <raprosa@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raphaelvrosa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
|
@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
Signed-off-by: Raphael Rosa <raprosa@redhat.com>
|
@raphaelvrosa: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@danwinship can you please take a look? |
make testcall that automates the updates of base CRD yamls.- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog