[release-4.22] OCPBUGS-86993: sanitize pin filenames to enable pinning subinterfaces#714
Conversation
The BPF fs does not allow dots (".") in filenames [1], which prevents
subinterfaces to be pinned correctly. By translating these dots before
writing to bpffs this allows pinning subinterfaces (e.g. vlans).
[1] https://github.com/torvalds/linux/blob/6146a0f1dfae5d37442a9ddcba012add260bceb0/kernel/bpf/inode.c#L371-L381
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/retitle [release-4.22] OCPBUGS-86993: sanitize pin filenames to enable pinning subinterfaces |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-86993, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bverschueren: This pull request references Jira Issue OCPBUGS-86993, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @anuragthehatter |
|
@anuragthehatter: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bverschueren: This pull request references Jira Issue OCPBUGS-86993, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #686
/assign bverschueren