Private field 'ONE_HOUR' is never used

[Pankraz76]

• [RSPEC-S1068] Remove unused private fields apache/maven#2317
• https://docs.openrewrite.org/recipes/staticanalysis/removeunusedprivatefields

assuming circle issue as last block item was found. ONE_DAY

[timtebeek]

Please use the issue templates we have to indicate clearly what was run, what was expected, and what you saw instead. A lot of that is implied here, but hard to be sure and that places a burden on us to then deduce or as all for more information, before we can even confirm if this is a bug that needs fixing.

[Pankraz76]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v1.2.3
• Maven/Gradle plugin v1.2.3
• rewrite-module v1.2.3

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>1.2.3</version>
  <configuration>
    ... 
  </configuration>
</plugin>

What is the smallest, simplest way to reproduce the problem?

public final class CLIReportingUtils {

    private static final long ONE_SECOND = 1000L;

    private static final long ONE_MINUTE = 60 * ONE_SECOND;

    private static final long ONE_HOUR = 60 * ONE_MINUTE;
}

What did you expect to see?

public final class CLIReportingUtils {}

What did you see instead?

public final class CLIReportingUtils {

    private static final long ONE_SECOND = 1000L;

    private static final long ONE_MINUTE = 60 * ONE_SECOND;
}

What is the full stack trace of any errors you encountered?

stacktrace output here

Are you interested in contributing a fix to OpenRewrite?

[timtebeek]

This fails to reproduce, possibly following the repeat added in 1b942fa.

    @Test
    void secondMinuteHour() {
        rewriteRun(
          //language=java
          java(
            """
              public class Test {
                  private static final long ONE_SECOND = 1000L;
                  private static final long ONE_MINUTE = 60 * ONE_SECOND;
                  private static final long ONE_HOUR = 60 * ONE_MINUTE;
              }
              """,
            """
              public class Test {
              }
              """
          )
        );
    }

I'd be fine to reopen the issue if you can produce a failing unit test against the latest version of rewrite-static-analysis. For now I'll close this issue.