From 5195385ddc4f8d3d0481ede74acbafb436bd5b80 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Risue=C3=B1o?=
 <ivan.risueno_martin.ext@boehringer-ingelheim.com>
Date: Fri, 4 Sep 2026 09:38:05 +0200
Subject: [PATCH 1/2] Set raw component url value when updating a component

---
 .../server/services/ProjectComponentsService.java         | 8 +-------
 .../server/services/ProjectComponentsServiceTest.java     | 2 +-
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/opendevstack/component_catalog/server/services/ProjectComponentsService.java b/src/main/java/org/opendevstack/component_catalog/server/services/ProjectComponentsService.java
index 9147240..7ff4f52 100644
--- a/src/main/java/org/opendevstack/component_catalog/server/services/ProjectComponentsService.java
+++ b/src/main/java/org/opendevstack/component_catalog/server/services/ProjectComponentsService.java
@@ -166,7 +166,7 @@ private ProjectComponent updateComponentIfMatch(Map.Entry<String, ProjectCompone
                 .catalogItemId(entry.getValue().getCatalogItemId())
                 .status(request.getStatus())
                 .catalogItemRef(resolveCatalogItemRef(entry.getValue(), request.getCatalogItemId()))
-                .componentUrl(resolveComponentUrl(entry.getValue(), request.getComponentUrl()))
+                .componentUrl(request.getComponentUrl()) // When a provision fails it should be able to update it to ""
                 .workflowJobId(resolveWorkflowJobId(entry.getValue(), request.getWorkflowJobId()))
                 .deletionWorkflowJobId(resolveDeletionWorkflowJobId(entry.getValue(), request.getDeletionWorkflowJobId()))
                 .createdAt(request.getCreatedAt())
@@ -181,12 +181,6 @@ private String resolveCatalogItemRef(ProjectComponent value, String catalogItemI
                 : getBranchRefFromCatalogItemId(catalogItemId);
     }
 
-    private String resolveComponentUrl(ProjectComponent value, String newUrl) {
-        return StringUtils.isBlank(newUrl)
-                ? value.getComponentUrl()
-                : newUrl;
-    }
-
     private List<Parameter> resolveParameters(ProjectComponent value, List<Parameter> params) {
         return (params == null || params.isEmpty())
                 ? value.getParameters()
diff --git a/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java b/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java
index f86e541..329df05 100644
--- a/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java
+++ b/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java
@@ -301,7 +301,7 @@ void givenExistingComponent_whenUpdatePartially_thenUpdatesOnlyFieldsProvided()
         ProjectComponent result = updated.getComponents().get("comp1");
 
         assertThat(result.getStatus()).isEqualTo(Status.CREATED);
-        assertThat(result.getComponentUrl()).isEqualTo("oldUrl"); // unchanged
+        assertThat(result.getComponentUrl()).isEqualTo(null);
         assertThat(result.getCatalogItemRef()).isEqualTo(base64("?at=refs/heads/dev"));
         assertThat(result.getCreatedAt()).isEqualTo("created");
         assertThat(result.getUpdatedAt()).isEqualTo("updated");

From a0a5e71522b20d34cca6653f2290d3048bc5811d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Risue=C3=B1o?=
 <ivan.risueno_martin.ext@boehringer-ingelheim.com>
Date: Fri, 4 Sep 2026 11:46:38 +0200
Subject: [PATCH 2/2] Improve one test

---
 .../server/services/ProjectComponentsServiceTest.java         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java b/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java
index 329df05..e28e259 100644
--- a/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java
+++ b/src/test/java/org/opendevstack/component_catalog/server/services/ProjectComponentsServiceTest.java
@@ -294,14 +294,14 @@ void givenExistingComponent_whenUpdatePartially_thenUpdatesOnlyFieldsProvided()
         //when
         ProjectComponents updated = service.updatePartiallyExistingComponent(
                 pc,
-                request("comp1", encodedFull, Status.CREATED, null, null, "created", "updated", parameters)
+                request("comp1", encodedFull, Status.CREATED, "", null, "created", "updated", parameters)
         );
 
         //then
         ProjectComponent result = updated.getComponents().get("comp1");
 
         assertThat(result.getStatus()).isEqualTo(Status.CREATED);
-        assertThat(result.getComponentUrl()).isEqualTo(null);
+        assertThat(result.getComponentUrl()).isEqualTo("");
         assertThat(result.getCatalogItemRef()).isEqualTo(base64("?at=refs/heads/dev"));
         assertThat(result.getCreatedAt()).isEqualTo("created");
         assertThat(result.getUpdatedAt()).isEqualTo("updated");