From 408c8744a6c46ec2d6eea98ab4ca7bb5f1f77fb4 Mon Sep 17 00:00:00 2001
From: Parth Sharma <parthrsharma1002@gmail.com>
Date: Sun, 13 Sep 2026 15:59:06 +0530
Subject: [PATCH] fix(WEB-1104): hide the Close action for already-closed
 clients

The client header Actions menu rendered Close unconditionally, so a
Closed client could open the Close Client form and submit it, only to
have Fineract reject the command with "Client is already closed."

Guard the entry on status !== 'Closed', the inverse of the existing
Reactivate guard beside it. This deliberately does not narrow to
=== 'Active': Fineract's closeClient permits Pending -> Closed (it only
rejects Closed and under-transfer clients), and closing a Pending client
from the menu is a legal, working flow today.

Supersedes #3796 by Farah Nahle.
---
 src/app/clients/clients-view/clients-view.component.html | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/app/clients/clients-view/clients-view.component.html b/src/app/clients/clients-view/clients-view.component.html
index 0b11b45763..41ba628cb0 100644
--- a/src/app/clients/clients-view/clients-view.component.html
+++ b/src/app/clients/clients-view/clients-view.component.html
@@ -287,7 +287,11 @@
   </mat-menu>
 
   <mat-menu #Actions="matMenu">
-    <button mat-menu-item (click)="doAction('Close')">{{ 'labels.buttons.Close' | translate }}</button>
+    @if (clientViewData.status.value !== 'Closed') {
+      <span
+        ><button mat-menu-item (click)="doAction('Close')">{{ 'labels.buttons.Close' | translate }}</button></span
+      >
+    }
     <button mat-menu-item (click)="doAction('Transfer Client')">
       {{ 'labels.buttons.Transfer Client' | translate }}
     </button>