Summary
Multiple test files contain repeated string literals (used >3 times) that should be extracted to constants for easier maintenance.
Affected Files
ReportModelBuilderParentChildTests.cs
ReportModelBuilderParentChildEdgeCaseTests.cs
ConfigurationReferenceResolverTests.cs
Parsing/TerraformPlanParserTests.cs
Providers/AzureDevOps/AzureDevOpsModule.cs
Common Repeated Literals
"managed" (15+ times)
"custom" (16+ times)
"create" (13+ times)
"custom_parent.team" (7 times)
"custom_child.member1" (4 times)
"group_object_id" (5 times)
"parent_id" (4+ times)
"member" (8+ times)
"descriptor" (4+ times)
"administrator" (4+ times)
Example Refactoring
// Before
var parent = CreateResource("custom_parent.team", "custom", "managed", ...);
var child = CreateResource("custom_child.member1", "custom", "managed", ...);
// After
private const string ParentAddress = "custom_parent.team";
private const string ChildAddress = "custom_child.member1";
private const string ParentType = "custom";
private const string Mode = "managed";
var parent = CreateResource(ParentAddress, ParentType, Mode, ...);
var child = CreateResource(ChildAddress, ParentType, Mode, ...);
Priority: Low
Effort: Small
Impact: Test maintainability improvement
Related Work
Notes
Test readability is clear as-is. This is a maintenance quality-of-life improvement for future test modifications.
Summary
Multiple test files contain repeated string literals (used >3 times) that should be extracted to constants for easier maintenance.
Affected Files
ReportModelBuilderParentChildTests.csReportModelBuilderParentChildEdgeCaseTests.csConfigurationReferenceResolverTests.csParsing/TerraformPlanParserTests.csProviders/AzureDevOps/AzureDevOpsModule.csCommon Repeated Literals
"managed"(15+ times)"custom"(16+ times)"create"(13+ times)"custom_parent.team"(7 times)"custom_child.member1"(4 times)"group_object_id"(5 times)"parent_id"(4+ times)"member"(8+ times)"descriptor"(4+ times)"administrator"(4+ times)Example Refactoring
Priority: Low
Effort: Small
Impact: Test maintainability improvement
Related Work
Notes
Test readability is clear as-is. This is a maintenance quality-of-life improvement for future test modifications.