From c9e5b2575e38e10b9daa0061c154a22336fcc9ef Mon Sep 17 00:00:00 2001 From: Eryk Wieliczko Date: Fri, 30 Oct 2026 23:23:15 +0100 Subject: [PATCH] drm/apple: turn DP/HDMI audio on by default DP/HDMI audio through the display coprocessor has been off unless appledrm.hdmi_audio=1 was set, so a distribution that wants it has to ship that option in a modprobe.d file. Make it the default and keep the parameter as the way to turn it off: appledrm.hdmi_audio=0 on the kernel command line, or "options appledrm hdmi_audio=0" in modprobe.d before the driver loads. The default applies to every machine the driver supports, M1 and M2 included. Signed-off-by: Eryk Wieliczko Assisted-by: Claude:claude-opus-5-5 --- drivers/gpu/drm/apple/av.h | 2 +- drivers/gpu/drm/apple/dcp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/apple/av.h b/drivers/gpu/drm/apple/av.h index 1d710b0f706f36..6d25d83d78d79d 100644 --- a/drivers/gpu/drm/apple/av.h +++ b/drivers/gpu/drm/apple/av.h @@ -6,7 +6,7 @@ //int avep_audiosrv_startlink(struct apple_dcp *dcp, struct dcp_sound_cookie *cookie); //int avep_audiosrv_stoplink(struct apple_dcp *dcp); -/* dcp.c: the opt-in to DP/HDMI audio (appledrm.hdmi_audio). */ +/* dcp.c: DP/HDMI audio, on unless appledrm.hdmi_audio=0. */ extern bool hdmi_audio; #if IS_ENABLED(CONFIG_DRM_APPLE_AUDIO) diff --git a/drivers/gpu/drm/apple/dcp.c b/drivers/gpu/drm/apple/dcp.c index 4c13e82ea60165..8c0c29b8edeb41 100644 --- a/drivers/gpu/drm/apple/dcp.c +++ b/drivers/gpu/drm/apple/dcp.c @@ -200,9 +200,9 @@ module_param(t6030_show_notch, bool, 0444); MODULE_PARM_DESC(t6030_show_notch, "M3 internal display (14.x and 26.6 IOMFB): use the full height and show the notch"); -bool hdmi_audio; +bool hdmi_audio = true; module_param(hdmi_audio, bool, 0644); -MODULE_PARM_DESC(hdmi_audio, "Enable unstable HDMI audio support"); +MODULE_PARM_DESC(hdmi_audio, "Enable DP/HDMI audio support (default: on)"); static bool unstable_edid = true; module_param(unstable_edid, bool, 0644); @@ -2535,7 +2535,7 @@ int dcp_start(struct platform_device *pdev) /* * A native T6030 external processor: its DP/HDMI audio endpoint (EP 0x29) - * on the driver's opt-in (hdmi_audio), as the other DCPs start it, for a + * unless hdmi_audio is off, as the other DCPs start it, for a * processor whose port@0 links an audio device; once per session, and after * the first display's EDID was read: with the endpoint's interfaces * published, an EDID copy (dcpavserv_copy_edid()) has the firmware rebuild