test: improve node:bench test coverage

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode

Author: jasnell

lib/internal/bench_runner/cli.js

@@ -428,6 +428,8 @@ function getChildArgs(path, options) {
     },
   );
   ArrayPrototypePushApply(args, unknownExecArgv);
+  // Option serialization omits port 0, which would otherwise become 9229.
+  if (process.debugPort === 0) ArrayPrototypePush(args, '--inspect-port=0');
   ArrayPrototypePush(args, '--bench', '--bench-isolation=none');
   if (options.namePatternSource.length > 0) {
     ArrayPrototypePush(

test/fixtures/bench-runner/abrupt-exit.cjs

@@ -0,0 +1,18 @@
+'use strict';
+
+const mode = process.env.NODE_BENCH_EXIT_MODE;
+
+if (mode === 'code') process.exit(2);
+if (mode === 'signal') process.kill(process.pid, 'SIGTERM');
+
+const { bench } = require('node:bench');
+
+if (mode === 'late') {
+  process.on('beforeExit', () => { process.exitCode = 2; });
+}
+
+bench('abrupt exit', { samples: 1 }, (b) => {
+  b.start();
+  process.hrtime.bigint();
+  b.end(1);
+});

test/fixtures/bench-runner/destroying-reporter.cjs

@@ -0,0 +1,8 @@
+'use strict';
+
+module.exports = async function* destroyingReporter(source) {
+  source.once('bench:start', () => {
+    source.destroy(new Error('benchmark reporter closed the stream'));
+  });
+  yield* source;
+};

test/fixtures/bench-runner/fake-ipc.cjs

@@ -0,0 +1,3 @@
+'use strict';
+
+process.send = () => {};

test/fixtures/bench-runner/inspector.cjs

@@ -0,0 +1,15 @@
+'use strict';
+
+const { bench } = require('node:bench');
+
+const inspectPort = process.execArgv.filter(
+  (arg) => arg.startsWith('--inspect-port=')).at(-1);
+
+bench('inspector option', {
+  params: { inspectPort },
+  samples: 1,
+}, (b) => {
+  b.start();
+  process.hrtime.bigint();
+  b.end(1);
+});

test/fixtures/bench-runner/malformed-record.cjs

@@ -0,0 +1,15 @@
+'use strict';
+
+const common = require('../../common');
+
+const record = process.env.NODE_BENCH_MALFORMED_RECORD === 'summary' ? {
+  type: 'bench:summary',
+  data: {
+    counts: { completed: 0, failed: 0, skipped: 0, total: -1 },
+    duration_ns: 1n,
+    success: true,
+  },
+} : null;
+
+process.send?.({ type: 'node:bench:record', record });
+setTimeout(() => process.exit(2), common.platformTimeout(10_000));

test/fixtures/bench-runner/many-records.cjs

@@ -0,0 +1,10 @@
+'use strict';
+
+const { bench } = require('node:bench');
+
+bench('many records', { samples: 30 }, (b) => {
+  process.stdout.write(`${b.index}\n`);
+  b.start();
+  process.hrtime.bigint();
+  b.end(1);
+});

test/fixtures/bench-runner/send-error.cjs

@@ -0,0 +1,17 @@
+'use strict';
+
+if (process.env.NODE_BENCH_SEND_ERROR === 'callback') {
+  process.send = (_message, _handle, _options, callback) => {
+    callback(new Error('benchmark send callback failed'));
+  };
+} else {
+  process.send = () => { throw new Error('benchmark send threw'); };
+}
+
+const { bench } = require('node:bench');
+
+bench('send error', { samples: 1 }, (b) => {
+  b.start();
+  process.hrtime.bigint();
+  b.end(1);
+});

test/fixtures/bench-runner/slow-reporter.cjs

@@ -0,0 +1,35 @@
+'use strict';
+
+const { setTimeout } = require('timers/promises');
+
+module.exports = async function* slowReporter(source) {
+  const { promise, resolve } = Promise.withResolvers();
+  let emitted = 0;
+  const onRecord = () => {
+    if (++emitted === source.readableHighWaterMark) resolve();
+  };
+  for (const type of [
+    'bench:start',
+    'bench:sample',
+    'bench:complete',
+    'bench:diagnostic',
+    'bench:summary',
+  ]) {
+    source.on(type, onRecord);
+  }
+  await promise;
+
+  let samples = 0;
+  let stdout = '';
+  for await (const record of source) {
+    await setTimeout(2);
+    if (record.type === 'bench:sample') samples++;
+    if (record.type === 'bench:diagnostic' &&
+        record.data.stream === 'stdout') {
+      stdout += record.data.message;
+    }
+    if (record.type === 'bench:summary') {
+      yield `${JSON.stringify({ samples, stdout })}\n`;
+    }
+  }
+};

test/fixtures/bench-runner/throws-null.cjs

@@ -0,0 +1,3 @@
+'use strict';
+
+throw null;