# 8e9cbf64bc5c617c7644ec0f917ce8a7030ce3c1 ok 1 assisted-by-is-trailer: no Assisted-by metadata ok 2 co-authored-by-is-trailer: Co-authored-by is a trailer ok 3 fixes-url: skipping fixes-url # SKIP ok 4 line-after-title: blank line after title not ok 5 line-length: Line should be <= 72 columns. --- { found: 382, compare: '<=', wanted: 72, at: { line: 2, column: 72, body: [ '', "Web IDL converts an assigned value to the attribute's type before the setter steps run. The URL component setters passed `this.#context.href` as the first argument to `bindingUrl.update()`, evaluating it before the assigned value's string conversion. A `toString()` that mutates the URL during conversion therefore had its effects overwritten by the stale href captured beforehand.\r", '\r', 'Hoist the conversion above the href read in the protocol, username, password, host, hostname, port, pathname, search and hash setters, matching the existing `href` setter.\r', '\r', 'Fixes: https://github.com/nodejs/node/issues/67345\r', '\r', 'Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>' ] } } ... not ok 6 line-length: Line should be <= 72 columns. --- { found: 172, compare: '<=', wanted: 72, at: { line: 4, column: 72, body: [ '', "Web IDL converts an assigned value to the attribute's type before the setter steps run. The URL component setters passed `this.#context.href` as the first argument to `bindingUrl.update()`, evaluating it before the assigned value's string conversion. A `toString()` that mutates the URL during conversion therefore had its effects overwritten by the stale href captured beforehand.\r", '\r', 'Hoist the conversion above the href read in the protocol, username, password, host, hostname, port, pathname, search and hash setters, matching the existing `href` setter.\r', '\r', 'Fixes: https://github.com/nodejs/node/issues/67345\r', '\r', 'Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>' ] } } ... not ok 7 signed-off-by: Commit must have a "Signed-off-by" trailer () --- { found: '', compare: '===', wanted: '', at: { line: 0, column: 0, body: [ '', "Web IDL converts an assigned value to the attribute's type before the setter steps run. The URL component setters passed `this.#context.href` as the first argument to `bindingUrl.update()`, evaluating it before the assigned value's string conversion. A `toString()` that mutates the URL during conversion therefore had its effects overwritten by the stale href captured beforehand.\r", '\r', 'Hoist the conversion above the href read in the protocol, username, password, host, hostname, port, pathname, search and hash setters, matching the existing `href` setter.\r', '\r', 'Fixes: https://github.com/nodejs/node/issues/67345\r', '\r', 'Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>' ] } } ... ok 8 subsystem: valid subsystems [url] ok 9 title-format: Title is formatted correctly. 0..9 # tests 9 # pass 5 # fail 3 # Please review the commit message guidelines: # https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade. npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. npm warn deprecated glob@7.2.3: Glob versions prior to v9 are