From 121faa2146e48fcd477436031132f9f13cac3c3e Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 5 Jan 2026 23:34:26 +0100 Subject: [PATCH 1/6] chore: add Release Please GHA workflow --- .github/workflows/release-please.yml | 18 ++++++++++++++++++ .release-please-manifest.json | 3 +++ release-please-config.json | 10 ++++++++++ 3 files changed, 31 insertions(+) create mode 100644 .github/workflows/release-please.yml create mode 100644 .release-please-manifest.json create mode 100644 release-please-config.json diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml new file mode 100644 index 0000000..4c3f24f --- /dev/null +++ b/.github/workflows/release-please.yml @@ -0,0 +1,18 @@ +name: Release Please + +on: + push: + branches: + - main + +permissions: + contents: write + pull-requests: write + +jobs: + release-please: + runs-on: ubuntu-latest + steps: + - uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0 + with: + release-type: simple diff --git a/.release-please-manifest.json b/.release-please-manifest.json new file mode 100644 index 0000000..001eb2c --- /dev/null +++ b/.release-please-manifest.json @@ -0,0 +1,3 @@ +{ + ".": "0.1.2" +} diff --git a/release-please-config.json b/release-please-config.json new file mode 100644 index 0000000..565533d --- /dev/null +++ b/release-please-config.json @@ -0,0 +1,10 @@ +{ + "packages": { + ".": { + "release-type": "simple", + "extra-files": [ + "CMakeLists.txt" + ] + } + } +} From 71605a0827508681e6b2e0f779f5177ec4727b9c Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 19 Jan 2026 23:29:00 +0100 Subject: [PATCH 2/6] squash! add necessary inline comment for release please to detect version string --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2dade34..bf4b059 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.28) -project(nbytes VERSION 0.1.2) +project(nbytes VERSION 0.1.2) # x-release-please-version set(CMAKE_CXX_STANDARD 20) set(CMAKE_CXX_STANDARD_REQUIRED True) From 3cb0316dd194a5055a0df66691d38dbd98e72dc6 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Tue, 20 Jan 2026 21:55:27 +0100 Subject: [PATCH 3/6] Update .github/workflows/release-please.yml --- .github/workflows/release-please.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 4c3f24f..57f8a91 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -14,5 +14,3 @@ jobs: runs-on: ubuntu-latest steps: - uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0 - with: - release-type: simple From 994e7d2000e1a8dc0737c0f6e895fa1c7b9c3c49 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 2 Feb 2026 17:04:11 +0100 Subject: [PATCH 4/6] add release-please comments in header file --- include/nbytes.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/nbytes.h b/include/nbytes.h index 525a917..f53e87f 100644 --- a/include/nbytes.h +++ b/include/nbytes.h @@ -836,12 +836,12 @@ size_t SearchString(const char *haystack, size_t haystack_length, // ============================================================================ // Version metadata -#define NBYTES_VERSION "0.1.1" +#define NBYTES_VERSION "0.1.2" // x-release-please-version enum { - NBYTES_VERSION_MAJOR = 0, - NBYTES_VERSION_MINOR = 1, - NBYTES_VERSION_REVISION = 1, + NBYTES_VERSION_MAJOR = 0, // x-release-please-major + NBYTES_VERSION_MINOR = 1, // x-release-please-minor + NBYTES_VERSION_REVISION = 2, // x-release-please-patch }; } // namespace nbytes From 8e6b160505f83586a112c802eb8b413a2d67ffe3 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 2 Feb 2026 17:05:11 +0100 Subject: [PATCH 5/6] Update release-please-config.json --- release-please-config.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/release-please-config.json b/release-please-config.json index 565533d..0793045 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -3,7 +3,8 @@ ".": { "release-type": "simple", "extra-files": [ - "CMakeLists.txt" + "CMakeLists.txt", + "include/nbytes.h" ] } } From d7708d3c9bea7e4c95971a26908269f9e6441090 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 2 Feb 2026 17:57:50 +0100 Subject: [PATCH 6/6] Apply suggestions from code review --- include/nbytes.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/nbytes.h b/include/nbytes.h index f53e87f..7fa347b 100644 --- a/include/nbytes.h +++ b/include/nbytes.h @@ -836,12 +836,12 @@ size_t SearchString(const char *haystack, size_t haystack_length, // ============================================================================ // Version metadata -#define NBYTES_VERSION "0.1.2" // x-release-please-version +#define NBYTES_VERSION "0.1.2" // x-release-please-version enum { - NBYTES_VERSION_MAJOR = 0, // x-release-please-major - NBYTES_VERSION_MINOR = 1, // x-release-please-minor - NBYTES_VERSION_REVISION = 2, // x-release-please-patch + NBYTES_VERSION_MAJOR = 0, // x-release-please-major + NBYTES_VERSION_MINOR = 1, // x-release-please-minor + NBYTES_VERSION_REVISION = 2, // x-release-please-patch }; } // namespace nbytes