From 348b3e89ca36c5c29d560eb2016c608f9b666000 Mon Sep 17 00:00:00 2001 From: Claudio Wunder Date: Fri, 6 Nov 2026 20:33:02 +0100 Subject: [PATCH] meta: look up only push runs for a PR's base Only push runs of generate.yml upload the `commit` artifact. A PR stacked on another PR's branch can find that PR's pull_request run for its base commit, so prepare tried to download an artifact that run never made, and failed. With -e push such a base finds no run, and prepare takes the path without a comparison that #1248 added. Assisted-by: Claude Opus 5.5 --- .github/workflows/generate.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml index 7588c49e5..2d2e288bd 100644 --- a/.github/workflows/generate.yml +++ b/.github/workflows/generate.yml @@ -53,7 +53,8 @@ jobs: run: | # `174604400` refers to `generate.yml`'s workflow ID, available at https://api.github.com/repos/nodejs/doc-kit/actions/workflows/generate.yml # The `databaseId` is a given runs run ID (Ref: https://docs.github.com/en/enterprise-cloud@latest/graphql/reference/objects#workflowrun) - ID=$(gh run list --repo $GITHUB_REPOSITORY -c $BASE_SHA -w 174604400 -L 1 --json databaseId --jq ".[].databaseId") + # Only `push` runs upload the `commit` artifact: a PR stacked on another PR's branch can find that PR's `pull_request` run for its base + ID=$(gh run list --repo $GITHUB_REPOSITORY -c $BASE_SHA -w 174604400 -e push -L 1 --json databaseId --jq ".[].databaseId") echo "run_id=$ID" >> $GITHUB_OUTPUT - name: Download metadata artifact