Skip to content

Commit bc42177

Browse files
nodeeeeeeclaude
andcommitted
Fix language override ignoring cache; fix BGE-M3 position_ids error
Language fix: - When --language is explicitly passed, auto-enable force-regenerate so cached English sections are not reused for Chinese notes (and vice versa). Previously, selecting Chinese produced English notes because existing cached section .md files were served from disk without checking their language. BGE-M3 fix: - Add trust_remote_code=True when loading BAAI/bge-m3 via SentenceTransformer in suggest_matches(). This fixes the "embeddings.position_ids status unexpected" error that occurs with newer sentence-transformers versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4e59a3b commit bc42177

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

note_generation.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,6 +1593,10 @@ def main() -> None:
15931593
if args.language:
15941594
NOTE_LANGUAGE = args.language
15951595
print(f"Note language: {NOTE_LANGUAGE}")
1596+
# Changing language invalidates cached sections — auto-enable force
1597+
if not args.force:
1598+
args.force = True
1599+
print(f" (force-regenerate enabled: language differs from cached sections)")
15961600

15971601
if args.course:
15981602
course_dir = COURSE_DATA_DIR / args.course

semantic_alignment.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1486,7 +1486,8 @@ def suggest_matches(
14861486
import torch
14871487
device = "cuda" if torch.cuda.is_available() else "cpu"
14881488
print(f" [match] Loading {model_name} on {device}...")
1489-
embedder = SentenceTransformer(model_name, device=device)
1489+
embedder = SentenceTransformer(model_name, device=device,
1490+
trust_remote_code=True)
14901491
all_texts = cap_texts + slide_texts
14911492
embs = embedder.encode(
14921493
all_texts,

0 commit comments

Comments
 (0)