Commit 744bf8a
committed
#3: Browse button on Settings page → Output Directory had no effect.
loadSettingsData() injects the Browse button into #conn-fields
asynchronously, but attachPageHandlers tried to bind the click handler
before the element existed. The optional chaining (?.) silently no-op'd.
Fix: await loadSettingsData() before binding handlers on page 6.
#4: Pipeline failed with "No module named 'canvasapi'" because env:check
only verified tqdm/requests/openai imports, missing several core deps that
downloader.py and other pipeline scripts need. Users could pass the first-
start wizard with a partially-installed venv and hit the cryptic crash
mid-pipeline. Fix: extend the env:check import probe to cover canvasapi,
PIL, fitz, pptx; also re-run checkEnv from the renderer right before
launching the pipeline so a regressed venv prompts the user to reinstall
instead of failing silently.
Verified: 26/26 jest tests pass; node --check on main.js and app.js clean.
1 parent 7ea3a7e commit 744bf8a
2 files changed
Lines changed: 24 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
984 | 984 | | |
985 | 985 | | |
986 | 986 | | |
987 | | - | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
988 | 992 | | |
989 | 993 | | |
990 | | - | |
991 | 994 | | |
992 | 995 | | |
993 | 996 | | |
994 | | - | |
995 | | - | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
996 | 1000 | | |
997 | 1001 | | |
998 | 1002 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1460 | 1460 | | |
1461 | 1461 | | |
1462 | 1462 | | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
1463 | 1475 | | |
1464 | 1476 | | |
1465 | 1477 | | |
| |||
1749 | 1761 | | |
1750 | 1762 | | |
1751 | 1763 | | |
1752 | | - | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
1753 | 1768 | | |
1754 | 1769 | | |
1755 | 1770 | | |
| |||
0 commit comments