fix(ci): show the server log when a Playwright test fails

The workflow step that shows the Nextcloud log on failure printed
nothing when a test had failed. With CI set, playwright/start-server.mjs
stops the test server when Playwright ends, and that removes the
container before the step can read the log from it.

@nextcloud/e2e-test-server saves the log first when
NEXTCLOUD_E2E_LOG_FILE is set, so the workflow now sets it to
test-results/nextcloud.log, and the step prints that file. The report
upload already includes test-results/, so the log is uploaded too.
Version 0.6.0 of the library read the log through the Docker copy API,
which cannot see the tmpfs the data directory is on, so it saved
nothing. The dependency moves to 0.6.1, which reads the log by running
cat inside the container; the lockfile changes in that package only.

If the server script fails during setup and leaves its container
running, the step falls back to reading the log from that container, as
it did before.

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>

Author: oleksandr-nc

.github/workflows/playwright.yml

@@ -91,10 +91,16 @@ jobs:
         run: npx playwright test
         env:
           BRANCH: ${{ matrix.server-versions }}
+          # stopNextcloud() saves the Nextcloud log here, if there is one, before it removes the container
+          NEXTCLOUD_E2E_LOG_FILE: test-results/nextcloud.log
 
       - name: Show Nextcloud log on failure
         if: failure()
-        run: docker ps -q --filter name=nextcloud-e2e-test-server | xargs -r -I{} docker exec {} cat data/nextcloud.log || true
+        # print the saved log, or else the log of a test server container that is still running
+        run: |
+          cat test-results/nextcloud.log 2>/dev/null \
+            || docker ps -q --filter name=nextcloud-e2e-test-server | xargs -r -I{} docker exec {} cat data/nextcloud.log \
+            || true
 
       - name: Upload Playwright report
         if: failure()

package-lock.json

@@ -64,7 +64,7 @@
   "devDependencies": {
     "@nextcloud/babel-config": "^1.2.0",
     "@nextcloud/browserslist-config": "^3.0.1",
-    "@nextcloud/e2e-test-server": "^0.6.0",
+    "@nextcloud/e2e-test-server": "^0.6.1",
     "@nextcloud/eslint-config": "^9.0.1",
     "@nextcloud/stylelint-config": "^3.0.1",
     "@nextcloud/vite-config": "^2.5.2",