docs: require user permission before editing jj config#1
Open
Techcable wants to merge 1 commit into
Open
Conversation
Add a config-permission guardrail across the skill. Editing jj config (jj config set / jj config edit, --user or --repo) writes persistent settings that silently alter later behavior (git.push/git.fetch redirect pushes; trunk() aliases change rebase targets), so it must be gated on explicit user approval rather than treated as a routine non-interactive operation. - SKILL.md: new Critical Rule - troubleshooting.md: reframe Configuration block (list = safe; writes = ask first) - bookmarks.md: permission callout on multi-remote config workflows - revsets.md: glob opt-in is a user-owned config change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this repo! I plan to use this for work, so I have forked and carefully reviewed it. I would prefer that config edits always require user permission:
Add a config-permission guardrail across the skill. Editing jj config (jj config set / jj config edit, --user or --repo) writes persistent settings that silently alter later behavior (git.push/git.fetch redirect pushes; trunk() aliases change rebase targets), so it must be gated on explicit user approval rather than treated as a routine non-interactive operation.