From c14ddb4cfb08050b573a54a84d2f2171816877b4 Mon Sep 17 00:00:00 2001 From: Dmitriy Date: Thu, 26 Apr 2018 17:42:20 +0300 Subject: [PATCH 1/4] add navigator check add navigator check --- lib/vttcue.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vttcue.js b/lib/vttcue.js index d838635..30f0a5f 100644 --- a/lib/vttcue.js +++ b/lib/vttcue.js @@ -60,7 +60,7 @@ function VTTCue(startTime, endTime, text) { var cue = this; - var isIE8 = (/MSIE\s8\.0/).test(navigator.userAgent); + var isIE8 = (typeof navigator !== "undefined") && (/MSIE\s8\.0/).test(navigator.userAgent); var baseObj = {}; if (isIE8) { From 8133fe2a32370a183d3b48409d1680778fd75088 Mon Sep 17 00:00:00 2001 From: Dmitriy Date: Sun, 18 Nov 2018 13:59:34 +0200 Subject: [PATCH 2/4] Update vtt.js --- lib/vtt.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/vtt.js b/lib/vtt.js index 66ab23f..071eb94 100644 --- a/lib/vtt.js +++ b/lib/vtt.js @@ -266,12 +266,12 @@ // Apply default values for any missing fields. cue.region = settings.get("region", null); cue.vertical = settings.get("vertical", ""); - cue.line = settings.get("line", "auto"); + //cue.line = settings.get("line", "auto"); cue.lineAlign = settings.get("lineAlign", "start"); cue.snapToLines = settings.get("snapToLines", true); cue.size = settings.get("size", 100); - cue.align = settings.get("align", "middle"); - cue.position = settings.get("position", "auto"); + //cue.align = settings.get("align", "middle"); + //cue.position = settings.get("position", "auto"); cue.positionAlign = settings.get("positionAlign", { start: "start", left: "start", From efd0f168226f427b75317dc70398ccbaae20f424 Mon Sep 17 00:00:00 2001 From: Dmitriy Date: Sun, 18 Nov 2018 14:11:44 +0200 Subject: [PATCH 3/4] Update vtt.js --- lib/vtt.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vtt.js b/lib/vtt.js index 071eb94..bf0a320 100644 --- a/lib/vtt.js +++ b/lib/vtt.js @@ -266,12 +266,12 @@ // Apply default values for any missing fields. cue.region = settings.get("region", null); cue.vertical = settings.get("vertical", ""); - //cue.line = settings.get("line", "auto"); + cue.line = settings.get("line", cue.line || "auto"); cue.lineAlign = settings.get("lineAlign", "start"); cue.snapToLines = settings.get("snapToLines", true); cue.size = settings.get("size", 100); //cue.align = settings.get("align", "middle"); - //cue.position = settings.get("position", "auto"); + cue.position = settings.get("position", cue.position || "auto"); cue.positionAlign = settings.get("positionAlign", { start: "start", left: "start", From 57f976c167ebe8870f0ae31cda1cdad817cd5621 Mon Sep 17 00:00:00 2001 From: Dmitriy Date: Sun, 18 Nov 2018 14:12:47 +0200 Subject: [PATCH 4/4] Update vttcue.js --- lib/vttcue.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/vttcue.js b/lib/vttcue.js index 30f0a5f..7701821 100644 --- a/lib/vttcue.js +++ b/lib/vttcue.js @@ -94,7 +94,8 @@ var _snapToLines = true; var _line = "auto"; var _lineAlign = "start"; - var _position = 50; + //var _position = 50; + var _position = "auto"; var _positionAlign = "middle"; var _size = 50; var _align = "middle";