Bug 2040748 - Implemented PasswordFileParser#260
Open
fmasalha wants to merge 1 commit into
Open
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
Alexandra-Virvara
approved these changes
May 22, 2026
Contributor
Alexandra-Virvara
left a comment
Alexandra-Virvara
left a comment
There was a problem hiding this comment.
This looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e
The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs
I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.