Skip to content

Commit 75b31b8

Browse files
authored
docs(ci): record that the dependency floors are smoke-tested only (#239)
Closes #236
1 parent 2a9fd06 commit 75b31b8

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎.github/workflows/_checks.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,11 @@ jobs:
136136
# pins each direct dependency to the floor pyproject.toml declares and bootstraps against it.
137137
# Per framework rather than all-extras at once: a floor declared in one extra pulls the shared
138138
# stack up for the others, so a combined resolution tests a set no user installs.
139+
# Runtime smoke only, by design (#236): pytest cannot run here because conftest.py hard-imports
140+
# opentelemetry, sentry_sdk and structlog, and `ty` would report the frameworks this target
141+
# deliberately did not install as unresolved. So nothing type-checks at the floor - an
142+
# annotation naming an optional dependency's internals has to span the declared range, and only
143+
# a human checks that.
139144
if: inputs.lowest-direct
140145
runs-on: ubuntu-latest
141146
strategy:

0 commit comments

Comments
 (0)