fix: correct three claims the review found the branch could not support

Author: lesnik512

compose2pod/parsing.py

@@ -161,12 +161,14 @@ def _classify_volume(volume: str) -> tuple[str, str | None]:
 # even when that letter is declared top-level, a declaration Docker ignores.
 # Two letters (`CC:\data:/var`) is an ordinary named-volume reference instead.
 #
-# podman refuses every mount either reading makes (measured, podman 4.9.3): a
-# colon inside a source has nowhere to go in a `-v` spec, which splits into at
-# most source:target:options (`invalid option type "/var"`), and a container
-# path that is not absolute is refused outright (`invalid container path`).
-# So the whole family is a rule-two refusal, and a one-character volume name
-# is reachable only through the long form, where Docker honours `source: v`.
+# podman refuses the anonymous readings outright (measured, podman 4.9.3): a
+# container path that is not absolute is an `invalid container path`, and no
+# spelling names one. The bind readings it does mount, through `--mount
+# type=bind`; only the short `-v` spec emitted here cannot, since that splits
+# into at most source:target:options (`invalid option type "/var"`). So the
+# bind half is a limitation rather than rule two, tracked in
+# docs/adr/0006-docker-rejection-parity.md. Either way, a one-character volume
+# name is reachable through the long form, where Docker honours `source: v`.
 _DRIVE_SHAPED_SOURCE = re.compile(r"^[a-zA-Z]:")
 
 

docs/adr/0006-docker-rejection-parity.md

@@ -14,9 +14,11 @@ Docker's verdict binds only on the document, not the host: `env_file` existence,
 negative on a top-level numeric key are facts about the machine that runs the script and are
 deferred to it. `tests/conformance/` runs both oracles for real over a probe matrix generated
 from `SERVICE_KEYS | STRUCTURAL_KEYS | IGNORED_SERVICE_KEYS`, so a new key is probed the moment
-it is added, and `tests/integration/refusals.py` measures the other side, pairing each refusal above
-with the `--mount` that expresses what Docker says the document means -- so a claim that podman
-cannot express something cannot go stale unnoticed either. Verdicts are per version: the rulings
+it is added, and `tests/integration/refusals.py` measures the other side, pairing the volume-family
+refusals above with the `--mount` that expresses what Docker says the document means, so a claim
+that podman cannot express something cannot go stale unnoticed either. The rest of the refusals get
+rows, and a gate that every site has one, under
+[#109](https://github.com/modern-python/compose2pod/issues/109). Verdicts are per version: the rulings
 here are measured against `docker compose config` v5.1.2 and podman 4.9.3. Two residuals are open by
 design: `depends_on` errors among services outside the target's closure are accepted here and
 rejected by Docker ([#87](https://github.com/modern-python/compose2pod/issues/87)), and the

tests/integration/conftest.py

@@ -30,14 +30,17 @@
 _PODMAN_VERDICTS: pytest.StashKey[list[str]] = pytest.StashKey()
 
 # A container that starts and exits immediately, so a probe's verdict is its mount's,
-# not its workload's. Shared with the scenario tests, which pull the same tag.
+# not its workload's.
 _PROBE_IMAGE = "busybox:1.36"
 
 
 def _podman_version() -> str:
     if _PODMAN is None:
         return "podman not installed"
-    proc = subprocess.run([_PODMAN, "--version"], capture_output=True, text=True, check=False)  # noqa: S603
+
+    proc = subprocess.run(  # noqa: S603 - _PODMAN is an absolute path from shutil.which
+        [_PODMAN, "--version"], capture_output=True, text=True, check=False
+    )
     return proc.stdout.strip() or "podman version unknown"
 
 

tests/integration/refusals.py

@@ -12,6 +12,11 @@
 would produce: a short `-v` spec re-splits on colons and so can fail for its own
 grammar rather than for podman's inability to mount, which would make a row pass
 for the wrong reason and hide an emit bug behind a parity claim.
+
+Not every refusal has a row yet. The drive-qualified *bind* readings
+(`C:\data:/var`, `C:data:/var`) are refused by the same site as the rows below
+but belong to no row, because podman does mount them through `--mount`
+(issue #111); the refusals outside the volume family are issue #109 phase 2.
 """
 
 from dataclasses import dataclass

tests/integration/test_podman_refusals.py

@@ -28,10 +28,3 @@ def test_a_documented_refusal_names_a_mount_podman_will_not_make(
     assert probe_podman(refusal.id, refusal.podman_argv) != 0, (
         "podman made the mount this document asks for, so refusing it is a limitation, not rule two"
     )
-
-
-def test_every_row_has_a_distinct_id() -> None:
-    """Ids label the summary lines and the parametrize cases; a duplicate hides one row behind another."""
-    ids = [refusal.id for refusal in REFUSALS]
-
-    assert sorted(ids) == sorted(set(ids))