Long-term API consistency issues (probably for a 2.0)?

[larsoner]

When looking through #13634, it occurred to me that every once in a while we are reminded of long-running API or consistency issues that pop up from time to time. A couple come to mind:

• get_data vs __getitem__ and use_rounding, whether a last sample is included or not, etc. -- for example In crop(tmin) versus get_data(tmin), tmin has a different meaning #13634
• picks=None meaning different combinations of (all vs data) x (exclude=() vs exclude="bads") in multiple places

... and I'm sure there are others I'm forgetting (happy to edit this comment based on discussions below if needed).

We could consider having a longer-term clean-up of things like this. I think it would make sense to plan these for a 2.0 release. Packages like pandas and NumPy I think have made strides in this direction cleaning up some long-standing issues in their code using major releases -- we could consider doing the same.

[dikshaa2909]

Hi @larsoner
I've opened #13726 to fix the crop(tmin) vs get_data(tmin) inconsistency mentioned here.

The fix adds use_rounding=True to TimeMixin._handle_tmin_tmax(), unifying both methods to use the same rounding semantics. All tests pass locally.

This addresses one of the API consistency issues flagged for potential 2.0 cleanup. Would appreciate a review when you get a chance , happy to adjust the approach if needed!

[drammock]

@dikshaa2909 that seems premature to me. Fixing long-term inconsistencies will likely require some discussion before we settle on the preferred way to do it.