From 4a117a8e0a524ba85f2c1b5be67b1b4021e8df05 Mon Sep 17 00:00:00 2001 From: Aleksandr Shevchuk Date: Fri, 23 Oct 2026 12:02:58 +0300 Subject: [PATCH] ci: install Chromium and Firefox without their system packages playwright install --with-deps fetched 51.6 MB of Ubuntu packages for Firefox and 25.9 MB for Chromium. Some runners reach the mirror at 40 to 100 kB/s: on 2026-10-23 that step took 8, 13 and 20 minutes, where it usually takes two seconds. Nothing it adds is used. The runner image ships Chrome and Firefox, so the libraries they link against are there; apt added fonts, Xvfb and FFmpeg's codecs, and the suites run headless and decode no video. WebKit keeps --with-deps: it needs GStreamer and the rest. Closes #73 Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cca22f8e..67360fe3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,11 @@ jobs: node-version: 22 cache: pnpm - run: pnpm install --frozen-lockfile - - run: pnpm --filter @missing-elements/h5p-offline-player exec playwright install --with-deps chromium + # Without --with-deps: the runner image ships Chrome and Firefox, so the libraries they link + # against are there, and what apt would add (fonts, Xvfb, FFmpeg's codecs) a headless suite that + # decodes no video does not use. Some runners reach Ubuntu's mirror at 40 kB/s, where that took + # up to 20 minutes (#73). + - run: pnpm --filter @missing-elements/h5p-offline-player exec playwright install chromium - run: pnpm typecheck - run: pnpm test - run: pnpm build @@ -41,6 +45,11 @@ jobs: fail-fast: false matrix: browser: [firefox, webkit] + # WebKit needs its system packages, GStreamer among them. Firefox, like Chromium above, has its + # libraries from the runner image. + include: + - browser: webkit + deps: --with-deps steps: - uses: actions/checkout@v5 - uses: pnpm/action-setup@v6 @@ -49,7 +58,7 @@ jobs: node-version: 22 cache: pnpm - run: pnpm install --frozen-lockfile - - run: pnpm --filter @missing-elements/h5p-offline-player exec playwright install --with-deps ${{ matrix.browser }} + - run: pnpm --filter @missing-elements/h5p-offline-player exec playwright install ${{ matrix.deps }} ${{ matrix.browser }} - run: pnpm test:engine env: H5P_TEST_BROWSER: ${{ matrix.browser }}