From 334b91763444a04e9a8dd2a50e3e3f0ae70a10ba Mon Sep 17 00:00:00 2001 From: Aleksandr Shevchuk Date: Sun, 1 Nov 2026 22:35:08 +0200 Subject: [PATCH] fix: minimatch 11 under @vscode/vsce, for Dependabot alert #4 (#104) vsce 4.0.0, and 4.1.0 too, takes minimatch ^10.2.6, and no 10 fixes GHSA-g3hv-75wg-m249: 11.0.1 is the first. vsce calls only minimatch() itself, to apply .vscodeignore, which 11 keeps. A pnpm override forces 11 under vsce, as for alert #3. With it, `vsce package` writes the same .vsix: 141 entries with the same names, sizes and CRCs. Closes #104 Co-Authored-By: Claude Opus 5.5 --- pnpm-lock.yaml | 15 +++++++++++---- pnpm-workspace.yaml | 6 ++++++ 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 95f40a85..dc94b7be 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -6,6 +6,7 @@ settings: overrides: '@azure/identity>@azure/msal-node': ^7.1.0 + '@vscode/vsce>minimatch': ^11.0.1 importers: @@ -641,6 +642,9 @@ packages: '@types/node': optional: true + '@isaacs/nonrecursive-glob-match@1.0.3': + resolution: {integrity: sha512-SI7kyKHq4XXDRozw+r9GlRZkia1ZkFrpLW98r2IC2Bpr8YkFGE3fvjzmxCG0x78A++69HmDNrDvSMYBZmHGpKA==} + '@jridgewell/resolve-uri@3.1.2': resolution: {integrity: sha512-bRISgCIjP20/tbWSPWMEi54QVPRZExkuD9lJL+UIxUKtwVJA8wW1Trb1jMs1RFXo1CBTNZ/5hpC9QvmKWdopKw==} engines: {node: '>=6.0.0'} @@ -1756,8 +1760,8 @@ packages: resolution: {integrity: sha512-VP79XUPxV2CigYP3jWwAUFSku2aKqBH7uTAapFWCBqutsbmDo96KY5o8uh6U+/YSIn5OxJnXp73beVkpqMIGhA==} engines: {node: '>=18'} - minimatch@10.2.6: - resolution: {integrity: sha512-vpLQEs+VLCr1nU0BXS07maYoFwlDAH0gngQuuttxIwutDFEMHq2blX+8vpgxDdK3J1PwjCJiep77OitTZ4Ll1A==} + minimatch@11.0.3: + resolution: {integrity: sha512-iny/40PEGkNJQ5/Pv6z3nm6FbRAby32GeZRjCUJk2WnNDbgPSTcdI+DDvLqsgBdD4cD5sMtMheqPPnehCCa8Nw==} engines: {node: 18 || 20 || >=22} mrmime@2.0.1: @@ -2509,6 +2513,8 @@ snapshots: optionalDependencies: '@types/node': 26.6.5 + '@isaacs/nonrecursive-glob-match@1.0.3': {} + '@jridgewell/resolve-uri@3.1.2': {} '@jridgewell/sourcemap-codec@1.6.0': {} @@ -2969,7 +2975,7 @@ snapshots: jsonc-parser: 3.3.1 marked: 18.1.2 mime: 1.6.0 - minimatch: 10.2.6 + minimatch: 11.0.3 parse5: 8.0.1 proper-lockfile: 4.1.2 read: 1.0.7 @@ -3467,8 +3473,9 @@ snapshots: mimic-function@5.0.1: {} - minimatch@10.2.6: + minimatch@11.0.3: dependencies: + '@isaacs/nonrecursive-glob-match': 1.0.3 brace-expansion: 5.0.12 mrmime@2.0.1: {} diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index f1e022c7..62e09ce7 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -23,5 +23,11 @@ ignoredBuiltDependencies: # vsce's Microsoft Entra sign-in, the one path that runs MSAL, fails here as it did on 6, with every # credential unavailable rather than an error from a changed API. Remove this once @azure/identity # takes 7: neither 4.14.0 nor 4.15.0-beta.1 does. +# @vscode/vsce takes minimatch ^10.2.6, and no 10 fixes GHSA-g3hv-75wg-m249 (medium, Dependabot alert +# #4): 11.0.1 is the first. vsce calls only `minimatch(path, pattern, { dot: true })`, to apply +# .vscodeignore, which 11 keeps; what 11 removed (makeRe, the AST, debug) it never calls. With 11, +# `vsce package` writes the same .vsix, every entry's name and CRC alike (2026-11-01). Remove this +# once vsce takes 11: 4.1.0 does not. overrides: '@azure/identity>@azure/msal-node': ^7.1.0 + '@vscode/vsce>minimatch': ^11.0.1