Skip to content

Commit 9e0879f

Browse files
miriamkwclaude
andcommitted
fix: resolve Windows circular dependency and macOS platform compatibility
Windows fixes: - Use windows-2022 runner (SDK 10.0.22621) instead of windows-latest (SDK 10.0.26100.0) - Revert to Swift 6.0 for LoopAlgorithm compatibility - Avoids "cyclic dependency in module ucrt: ucrt -> _Builtin_intrinsics -> ucrt" error macOS fixes: - Add explicit platform requirements to Package.swift - Set minimum macOS 13.0 to match LoopAlgorithm dependency requirements - Resolves "library requires macos 10.13 but depends on product which requires macos 13.0" Based on research from Swift issues #79745 and #58450 showing SDK compatibility problems. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 6e977d1 commit 9e0879f

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false # Prevents one OS from stopping others from building
1414
matrix:
15-
os: [macos-latest, ubuntu-latest, windows-latest]
15+
os: [macos-latest, ubuntu-latest, windows-2022]
1616
runs-on: ${{ matrix.os }}
1717
outputs:
1818
target_branch: ${{ steps.vars.outputs.target_branch }}
@@ -39,10 +39,10 @@ jobs:
3939
swift-version: "6.0"
4040

4141
- name: Set up Swift (Windows)
42-
if: matrix.os == 'windows-latest'
42+
if: matrix.os == 'windows-2022'
4343
uses: SwiftyLab/setup-swift@latest
4444
with:
45-
swift-version: "5.10"
45+
swift-version: "6.0"
4646

4747
- name: Install dependencies
4848
shell: bash
@@ -65,7 +65,7 @@ jobs:
6565
EXPECTED_LIB="loop_to_python_api/dlibs/macos/libLoopAlgorithmToPython.dylib"
6666
elif [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
6767
EXPECTED_LIB="loop_to_python_api/dlibs/linux/libLoopAlgorithmToPython.so"
68-
elif [[ "${{ matrix.os }}" == "windows-latest" ]]; then
68+
elif [[ "${{ matrix.os }}" == "windows-2022" ]]; then
6969
EXPECTED_LIB="loop_to_python_api/dlibs/windows/libLoopAlgorithmToPython.dll"
7070
fi
7171

Package.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ import PackageDescription
44
let package = Package(
55
name: "LoopAlgorithmToPython",
66
defaultLocalization: "no",
7+
platforms: [
8+
.macOS(.v13),
9+
.iOS(.v15),
10+
.tvOS(.v15),
11+
.watchOS(.v8)
12+
],
713
products: [
814
.library(
915
name: "LoopAlgorithmToPython",

0 commit comments

Comments
 (0)