Add test for get_loop_recommendations and fix helper function import

- Added test coverage for get_loop_recommendations function
- Fixed helpers.get_bytes_from_json import issue in api.py
- Started addressing platform-specific type compatibility issues
- Still working on LoopAlgorithm type mismatch in getDynamicCarbsOnBoard

Author: miriamkw

Sources/LoopAlgorithmToPython/LoopAlgorithmToPython.swift

@@ -32,11 +32,11 @@ struct AlgorithmFactory {
     static func createScheduleValue(startDate: Date, endDate: Date, value: Double, unit: String) -> AbsoluteScheduleValue<AlgorithmValue> {
         #if os(Linux) || os(Windows)
             // Linux wants the raw Double
-            return AbsoluteScheduleValue<Double>(startDate: startDate, endDate: endDate, value: value)
+            return AbsoluteScheduleValue<AlgorithmValue>(startDate: startDate, endDate: endDate, value: value)
         #else
             // Mac wants the LoopQuantity object
             let quantity = LoopQuantity(unit: LoopUnit(from: unit), doubleValue: value)
-            return AbsoluteScheduleValue<LoopQuantity>(startDate: startDate, endDate: endDate, value: quantity)
+            return AbsoluteScheduleValue<AlgorithmValue>(startDate: startDate, endDate: endDate, value: quantity)
         #endif
     }
 }
@@ -438,14 +438,9 @@ public func getDynamicCarbsOnBoard(jsonData: UnsafePointer<Int8>?) -> Double {
         let startDate = dateFormatter.date(from: input.inputICE[0].startAt)!
         let endDate = dateFormatter.date(from: input.inputICE.last!.startAt)!
 
-        // Use the factory to get the right type for the current OS
-        let carbRatio: [AbsoluteScheduleValue<AlgorithmValue>] = [
-            AlgorithmFactory.createScheduleValue(startDate: startDate, endDate: endDate, value: input.carbRatio, unit: "g/U")
-        ]
-
-        let isf: [AbsoluteScheduleValue<AlgorithmValue>] = [
-            AlgorithmFactory.createScheduleValue(startDate: startDate, endDate: endDate, value: input.sensitivity, unit: "mg/dL/U")
-        ]
+        // Create schedule values with Double values as expected by the function
+        let carbRatio = [AbsoluteScheduleValue(startDate: startDate, endDate: endDate, value: input.carbRatio)]
+        let isf = [AbsoluteScheduleValue(startDate: startDate, endDate: endDate, value: input.sensitivity)]
 
         let statuses = [carbEntries[0]].map(
             to: inputICE,

loop_to_python_api/api.py

@@ -143,7 +143,7 @@ def get_active_insulin(json_file):
     return swift_lib.getActiveInsulin(json_bytes)
 
 def get_loop_recommendations(json_file, len=72):
-    json_bytes = get_bytes_from_json(json_file)
+    json_bytes = helpers.get_bytes_from_json(json_file)
 
     swift_lib.getLoopRecommendations.argtypes = [ctypes.c_char_p]
     swift_lib.getLoopRecommendations.restype = ctypes.c_char_p

python_tests/tests.py

@@ -10,6 +10,7 @@
     get_glucose_effect_velocity_and_dates,
     get_active_carbs,
     get_active_insulin,
+    get_loop_recommendations,
     percent_absorption_at_percent_time,
     piecewise_linear_percent_rate_at_percent_time,
     linear_percent_rate_at_percent_time,
@@ -122,6 +123,12 @@ def test_get_dynamic_carbs_on_board():
     assert isinstance(dynamic_carbs_on_board, float)
 
 
+def test_get_loop_recommendations():
+    loop_algorithm_input = get_loop_algorithm_input()
+    loop_recommendations = get_loop_recommendations(loop_algorithm_input)
+    assert isinstance(loop_recommendations, str)
+
+
 def test_insulin_percent_effect_remaining():
     # Test with typical rapid-acting insulin parameters
     result = insulin_percent_effect_remaining(