From 91a672b37182404895d4c2371a292dbe76cca11e Mon Sep 17 00:00:00 2001 From: na2co3 Date: Sat, 19 Sep 2026 11:24:51 +0900 Subject: [PATCH] Modern UI: Fix redundant tab action fading in connected editor tabs --- .../contrib/modernUI/browser/media/connectedEditorTabs.css | 4 ---- src/vs/workbench/contrib/modernUI/browser/media/tabs.css | 4 ++-- .../modernUI/test/browser/modernUI.contribution.test.ts | 2 ++ 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/modernUI/browser/media/connectedEditorTabs.css b/src/vs/workbench/contrib/modernUI/browser/media/connectedEditorTabs.css index 55933caa1a4cb5..8d6af3c07c6f36 100644 --- a/src/vs/workbench/contrib/modernUI/browser/media/connectedEditorTabs.css +++ b/src/vs/workbench/contrib/modernUI/browser/media/connectedEditorTabs.css @@ -374,10 +374,6 @@ pointer-events: auto; } -.modern-ui.modern-ui-connected-editor-tabs.monaco-workbench .part.editor > .content .editor-group-container > .title.tabs .tabs-container > .tab > .tab-actions::before { - content: none; -} - /* Terminal shoulders turn inside the available slot rather than being cut off. */ .modern-ui.modern-ui-connected-editor-tabs.monaco-workbench .part.editor > .content .editor-group-container > .title.tabs .tabs-container > .tab.active:not(.connected-tab-upper-row):is(:last-child, .last-in-row, .connected-tab-right-edge) > :is(.tab-fill, .tab-connected-edge) { right: var(--modern-ui-connected-tab-shoulder-radius); diff --git a/src/vs/workbench/contrib/modernUI/browser/media/tabs.css b/src/vs/workbench/contrib/modernUI/browser/media/tabs.css index 8327533709823c..2587bb6cefadc7 100644 --- a/src/vs/workbench/contrib/modernUI/browser/media/tabs.css +++ b/src/vs/workbench/contrib/modernUI/browser/media/tabs.css @@ -401,8 +401,8 @@ top: var(--vscode-spacing-size20); } -.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title:not(.tab-actions-reserve-space) .tabs-container > .tab:not(.dirty):not(.sticky):not(.close-action-off):hover > .tab-actions::before, -.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title:not(.tab-actions-reserve-space) .tabs-container > .tab:not(.dirty):not(.sticky):not(.close-action-off) > .tab-actions:focus-within::before { +.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title:not(.tab-actions-reserve-space, .connected-tabs-labels) .tabs-container > .tab:not(.dirty):not(.sticky):not(.close-action-off):hover > .tab-actions::before, +.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title:not(.tab-actions-reserve-space, .connected-tabs-labels) .tabs-container > .tab:not(.dirty):not(.sticky):not(.close-action-off) > .tab-actions:focus-within::before { content: ''; position: absolute; top: 0; diff --git a/src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts b/src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts index c62e0add89f24f..d920d6745e8025 100644 --- a/src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts +++ b/src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts @@ -2962,11 +2962,13 @@ suite('ModernUIContribution', () => { assert.deepStrictEqual({ overlaid: getFadeContent('title', 'tab'), reserved: getFadeContent('title tab-actions-reserve-space', 'tab'), + connected: getFadeContent('title connected-tabs-labels', 'tab'), dirty: getFadeContent('title', 'tab dirty'), sticky: getFadeContent('title', 'tab sticky'), }, { overlaid: '""', reserved: 'none', + connected: 'none', dirty: 'none', sticky: 'none', });