From ddfbf50e132cd0aa2215cd70a1afde6df9dda934 Mon Sep 17 00:00:00 2001 From: Bill Schnurr Date: Sun, 13 Sep 2026 22:57:53 -0700 Subject: [PATCH 1/4] Add blocking pandas-stubs primer check --- .github/workflows/mypy_primer_pr.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/mypy_primer_pr.yaml b/.github/workflows/mypy_primer_pr.yaml index dc01e9a39263..ad3fa3b0ac96 100644 --- a/.github/workflows/mypy_primer_pr.yaml +++ b/.github/workflows/mypy_primer_pr.yaml @@ -109,6 +109,12 @@ jobs: --output concise \ | tee diff_${{ matrix.shard-index }}.txt ) || [ $? -eq 1 ] + # pandas-stubs is a high-signal compatibility canary. Unlike the full + # corpus comparison above, any change in its diagnostics is blocking. + - if: ${{ matrix.shard-index == 0 }} + name: Require stable pandas-stubs diagnostics + shell: bash + run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --base-dir "$MYPY_PRIMER_BASE_DIR" --debug --output concise - name: Upload mypy_primer diff uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: From 62ec4c09a832b25af1311e182c67f3dc5287ba61 Mon Sep 17 00:00:00 2001 From: Bill Schnurr Date: Sun, 13 Sep 2026 22:58:19 -0700 Subject: [PATCH 2/4] Fix pandas-stubs primer command --- .github/workflows/mypy_primer_pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mypy_primer_pr.yaml b/.github/workflows/mypy_primer_pr.yaml index ad3fa3b0ac96..b92271d02762 100644 --- a/.github/workflows/mypy_primer_pr.yaml +++ b/.github/workflows/mypy_primer_pr.yaml @@ -114,7 +114,7 @@ jobs: - if: ${{ matrix.shard-index == 0 }} name: Require stable pandas-stubs diagnostics shell: bash - run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --base-dir "$MYPY_PRIMER_BASE_DIR" --debug --output concise + run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --debug --output concise - name: Upload mypy_primer diff uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: From b13766b1f383e1c2e32d531380b5081ad78d6b68 Mon Sep 17 00:00:00 2001 From: Bill Schnurr Date: Sun, 13 Sep 2026 22:58:55 -0700 Subject: [PATCH 3/4] Preserve primer artifacts before compatibility gate --- .github/workflows/mypy_primer_pr.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/mypy_primer_pr.yaml b/.github/workflows/mypy_primer_pr.yaml index b92271d02762..e9f40566b328 100644 --- a/.github/workflows/mypy_primer_pr.yaml +++ b/.github/workflows/mypy_primer_pr.yaml @@ -109,12 +109,6 @@ jobs: --output concise \ | tee diff_${{ matrix.shard-index }}.txt ) || [ $? -eq 1 ] - # pandas-stubs is a high-signal compatibility canary. Unlike the full - # corpus comparison above, any change in its diagnostics is blocking. - - if: ${{ matrix.shard-index == 0 }} - name: Require stable pandas-stubs diagnostics - shell: bash - run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --debug --output concise - name: Upload mypy_primer diff uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: @@ -130,3 +124,9 @@ jobs: with: name: mypy_primer_diffs_pr_number path: pr_number.txt + # pandas-stubs is a high-signal compatibility canary. Unlike the full + # corpus comparison above, any change in its diagnostics is blocking. + - if: ${{ matrix.shard-index == 0 }} + name: Require stable pandas-stubs diagnostics + shell: bash + run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --debug --output concise From 87dc48c32a4361448f342e19a30b998c4e755fea Mon Sep 17 00:00:00 2001 From: Bill Schnurr Date: Mon, 14 Sep 2026 00:13:54 -0700 Subject: [PATCH 4/4] Gate only pandas-stubs regressions from a clean base --- .github/workflows/mypy_primer_pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mypy_primer_pr.yaml b/.github/workflows/mypy_primer_pr.yaml index e9f40566b328..b01423f3bf18 100644 --- a/.github/workflows/mypy_primer_pr.yaml +++ b/.github/workflows/mypy_primer_pr.yaml @@ -129,4 +129,4 @@ jobs: - if: ${{ matrix.shard-index == 0 }} name: Require stable pandas-stubs diagnostics shell: bash - run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --debug --output concise + run: mypy_primer --repo pyright_to_test --type-checker pyright --new new_commit --old base_commit --project-selector 'pandas-dev/pandas-stubs' --old-success --debug --output concise