Skip to content

Fix token count mismatch in Agents dashboard for nested LangGraph setups #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hectorhdzg wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −6
Open

Fix token count mismatch in Agents dashboard for nested LangGraph setups #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/microsoft/opentelemetry/_genai/_langchain/_tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ def _is_agent_run(self, run: Run) -> bool:
"""Detect whether a LangChain run should be the top-level agent span."""
if not self._is_agent_like_chain(run):
return False
# Don't nest agents — if a parent is already an agent, this is internal
if run.parent_run_id and run.parent_run_id in self._agent_run_ids:
# Don't nest agents — if any ancestor is already an agent, this is internal
if self._find_agent_ancestor(run) is not None:
return False
return True

Expand Down
22 changes: 18 additions & 4 deletions tests/langchain/test_tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,22 @@ def test_non_agent_returns_false(self):
run = _make_run(run_type="chain", name="RunnableSequence")
self.assertFalse(tracer._is_agent_run(run))

def test_deeply_nested_agent_returns_false(self):
"""Agent-like chain nested under a non-agent chain whose ancestor is
already an agent must NOT be treated as a separate agent. This
prevents token aggregation from splitting across multiple agent
spans (see token-count mismatch in multi-agent LangGraph setups)."""
tracer, _, _ = _make_tracer()
agent_id = uuid4()
chain_id = uuid4()
tracer._agent_run_ids.add(agent_id)
# Intermediate non-agent chain between top-level agent and sub-graph.
chain_run = _make_run(run_type="chain", name="node_step", id=chain_id, parent_run_id=agent_id)
tracer.run_map[str(chain_id)] = chain_run
# Sub-graph whose direct parent is the intermediate chain, not the agent.
sub_graph = _make_run(run_type="chain", name="SubAgentGraph", parent_run_id=chain_id)
self.assertFalse(tracer._is_agent_run(sub_graph))


# ---- Agent name resolution ---------------------------------------------------

Expand Down Expand Up @@ -760,6 +776,7 @@ def test_attach_uses_inner_span_for_agent(self, mock_ctx):
self.assertIs(attach_call_args[0][0], inner_span)
mock_ctx.attach.assert_called_once()


# ---- invoke_agent aggregation fixes (issue #172) -----------------------------


Expand Down Expand Up @@ -1070,9 +1087,7 @@ def test_tool_role_message_becomes_tool_call_response(self):
"id": ["langchain", "schema", "messages", "AIMessage"],
"kwargs": {
"content": "",
"tool_calls": [
{"name": "get_weather", "args": {"location": "Paris"}, "id": "tc1"}
],
"tool_calls": [{"name": "get_weather", "args": {"location": "Paris"}, "id": "tc1"}],
"type": "ai",
},
},
Expand All @@ -1086,4 +1101,3 @@ def test_tool_role_message_becomes_tool_call_response(self):
self.assertEqual(tool_part.type, "tool_call_response")
self.assertEqual(tool_part.id, "tc1")
self.assertEqual(tool_part.response, "rainy")

Loading